Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddOn Skins Embeds not working #204

Open
nhtwolf opened this issue Aug 12, 2024 · 2 comments
Open

AddOn Skins Embeds not working #204

nhtwolf opened this issue Aug 12, 2024 · 2 comments

Comments

@nhtwolf
Copy link

nhtwolf commented Aug 12, 2024

I have Details! embeded in the right chat window and this is not working in the newest version. Looking into this I realized that AddOn Skins was not showing in the listed plugins for ElvUI. Looking into the changes between the older working version and the new non-working one I narrowed it down to be the change in line 55 of Init.lua:
old
AS.MyName = UnitName('player')
new
_, AS.MyName = UnitName('player')

Reverting this corrects the issue. Looking at the API this call should return name and realm but with name being ignored it stores the realm instead. I'm new to Lua/API so this may be intential but wanted to bring it to your attention if not. Thanks for all your work.

@Azilroka
Copy link
Owner

Yes, I put it in the wrong location

@nhtwolf
Copy link
Author

nhtwolf commented Aug 13, 2024

No worries, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants