Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why IntentAction is not called IntentCall? #11274

Open
olehmisar opened this issue Jan 16, 2025 · 1 comment
Open

Why IntentAction is not called IntentCall? #11274

olehmisar opened this issue Jan 16, 2025 · 1 comment
Labels
from-community This originated from the community :)

Comments

@olehmisar
Copy link
Contributor

What does "action" mean? Isn't it an intent to make a "call"? The type of IntentAction.action is literally FunctionCall. It's a nit but I am designing wallet JSON RPC interface, so worth renaming if it makes sense.

from https://discord.com/channels/1144692727120937080/1329324356282748989
@critesjosh critesjosh added the from-community This originated from the community :) label Jan 17, 2025
@dsarfed dsarfed mentioned this issue Jan 24, 2025
Closed
@ludamad
Copy link
Collaborator

ludamad commented Jan 26, 2025 •
edited
Loading

Actually, it's not 'literally FunctionCall'. The only argument against I can think is it makes use of ContractFunctionInteraction which makes a case that this does more than calls

 * This is the class that is returned when calling e.g. `contract.methods.myMethod(arg0, arg1)`.
 * It contains available interactions one can call on a method, including view.

@LHerskind think it's worthy to change regardless?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
from-community This originated from the community :)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ludamad @critesjosh @olehmisar