Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StationClient: history parameters are never used #35

Open
hwalker928 opened this issue Sep 4, 2024 · 0 comments
Open

StationClient: history parameters are never used #35

hwalker928 opened this issue Sep 4, 2024 · 0 comments

Comments

@hwalker928
Copy link

The function history takes in two parameters, start and end. These never seem to be passed to the request itself.

image
chrisvandergeld added a commit to chrisvandergeld/php-api-client that referenced this issue Jan 26, 2025
@chrisvandergeld
Fixing history according to issue AzuraCast#35
b095ae3 
The history function didn't implement the $start and $end variables it requests from the user. It now properly uses the variables to gather the correct history in a specific timeframe.
@chrisvandergeld chrisvandergeld mentioned this issue Jan 26, 2025
Merged
BusterNeece added a commit that referenced this issue Jan 27, 2025
@BusterNeece
Merge pull request #36 from Tailchakra/main
1491b94 
Fixing history according to issue #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hwalker928