Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_index.py: index_name hardcoded in python file, .env AZUREAI_SEARCH_INDEX_NAME is ignored #32

Open
bmerkle opened this issue Sep 2, 2024 · 1 comment

Comments

@bmerkle
Copy link

bmerkle commented Sep 2, 2024

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

in build_index.py the index name is hardcoded to "tutorial-index". However the index can also be specified via the .env file.
IMO the .env file should be read and only if there is no value, we should set a default value (to e.g. "tutorial-index)

hard coded value:

index_name = "tutorial-index" # your desired index name

env specified value:
AZURE_OPENAI_EVALUATION_DEPLOYMENT=

Any log messages given by the failure

Expected/desired behavior

index name should be read from value specified in the .env file

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

bmerkle added a commit to bmerkle/rag-data-openai-python-promptflow that referenced this issue Sep 2, 2024
@bmerkle
Copy link
Author

bmerkle commented Sep 2, 2024

Additionally i think the documentation has to be fixed.
Setting the index-name in the .env file has to be done before running the build-index.py program

https://learn.microsoft.com/en-us/azure/ai-studio/tutorials/copilot-sdk-build-rag?tabs=azure-portal#set-the-search-index-environment-variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant