Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure generated code works in browser for RLC and Modular #2980

Open
MaryGao opened this issue Jan 8, 2025 · 1 comment
Open

Make sure generated code works in browser for RLC and Modular #2980

MaryGao opened this issue Jan 8, 2025 · 1 comment
Labels

Comments

@MaryGao
Copy link
Member

MaryGao commented Jan 8, 2025

Recently we recieved customer's issue for browser usage, but we haven't enabled browser testing for generated code yet. It's better to have that no matter unbranded or azure clients in both Modular and RLC.

In autorest we have the browser testing for HLC and RLC and see code here.

"test:node": "npm run unit-test && npm run start-test-server:v2 & npm run integration-test:alone & npm run rlc-integration-test:alone & npm run test-version-tolerance & npm run stop-test-server",
"test:node:alone": "npm run unit-test && npm run integration-test:alone && npm run rlc-integration-test:alone && npm run test-version-tolerance",
"test:browser": "npm run start-test-server:v2 & npm run integration-test:browser & npm run rlc-integration-test:browser & npm run test-version-tolerance & npm run stop-test-server",
"test:browser:alone": "npm run integration-test:browser && npm run rlc-integration-test:browser && npm run test-version-tolerance",

We could have similar steps to enable the brower testing for cadl-ranch cases. Considering we have browser coverage for azure-rlc so I think this is nice to have features but for other cases there exist testing gaps so they are must. But enabling all testing may be time-consuming we need to decide if we could select possible cases included.

"integration-test:alone:rlc": "cross-env TS_NODE_PROJECT=tsconfig.integration.json mocha -r ts-node/register --experimental-specifier-resolution=node --timeout 36000 ./test/integration/*.spec.ts",
"integration-test:alone:azure-rlc": "cross-env TS_NODE_PROJECT=tsconfig.integration.json mocha -r ts-node/register --experimental-specifier-resolution=node --timeout 36000 ./test/azureIntegration/*.spec.ts",
"integration-test:alone:modular": "cross-env TS_NODE_PROJECT=tsconfig.integration.json mocha -r ts-node/register --experimental-specifier-resolution=node --timeout 36000 ./test/modularIntegration/*.spec.ts",
"integration-test:alone:azure-modular": "cross-env TS_NODE_PROJECT=tsconfig.integration.json mocha -r ts-node/register --experimental-specifier-resolution=node --timeout 36000 ./test/azureModularIntegration/*.spec.ts",

  • testing for azure-rlc(nice to have)
  • testing for unbranded-rlc(must to have)
  • testing for azure-modular(must to have)
  • testing for unbranded-modular(must to have)
@MaryGao MaryGao changed the title Include browser testing for esm Modular and RLC Add browser testing for esm Modular and RLC Jan 8, 2025
@qiaozha qiaozha added P1 priority 1 RLC HRLC labels Jan 8, 2025
@qiaozha
Copy link
Member

qiaozha commented Jan 23, 2025

Enable the whole spector tests on the browser environment would be too much and I feel like it will probably impact the ci efficiency? Maybe we could just select a few typical spector test cases here?

@MaryGao MaryGao changed the title Add browser testing for esm Modular and RLC Make sure generated code works in browser for RLC and Modular Jan 23, 2025
@MaryGao MaryGao added p0 priority 0 and removed P1 priority 1 labels Jan 23, 2025
@MaryGao MaryGao removed their assignment Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants