Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modular] Ensure the metadata is the latest and update tsconfig.json #3019

Open
Tracked by #2986
MaryGao opened this issue Jan 22, 2025 · 2 comments
Open
Tracked by #2986

[Modular] Ensure the metadata is the latest and update tsconfig.json #3019

MaryGao opened this issue Jan 22, 2025 · 2 comments
Labels
HRLC p0 priority 0

Comments

@MaryGao
Copy link
Member

MaryGao commented Jan 22, 2025

This is the same as #3020 but for Modular from typespec and we could implement them together.

Below two commits are updated after the execution of the migrate tool. We should ensure the change is applied in Modular and I think only the change of tsconfig.xxx.json needs to be updated.

The impacted files are with below:

  • tsconfig.xxx.json
  • vitest.xxx.config.ts
@MaryGao
Copy link
Member Author

MaryGao commented Jan 23, 2025

@kazrael2119 Could you help me understand the following questions?

  • which files do we need to update?
  • does this impact for azure and unbranded?

@MaryGao MaryGao added p0 priority 0 HRLC labels Jan 23, 2025
@kazrael2119
Copy link
Contributor

for modular:
1 we need separate tsconfig.json to tsconfig.json, tsconfig.src.json, tsconfig.samples.json, tsconfig.test.json
see Azure/azure-sdk-for-js@530ec99#diff-551daf95f9048851e1a0c254942e6efce4ca19a753e32c2203dab683a62d13b3
2
create tsconfig.browser.config.json and vitest.esm.config.ts
update vitest.config.ts and vitest.browser.config.ts
see Azure/azure-sdk-for-js@4a970fe#diff-417e4ee0e906f553a5abfce657c6b886bb95dba9f8a8f4a15e74e6f3c75da45b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC p0 priority 0
Projects
None yet
Development

No branches or pull requests

2 participants