Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGINT and SIGTERM for Node.js process #3148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle SIGINT and SIGTERM for Node.js process #3148

wants to merge 1 commit into from

Conversation

beyerleinf
Copy link

Issue describing the changes in this PR

resolves #3074

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju
Copy link
Member

kshyju commented Jul 3, 2024

Tagging @ejizba for review.

liliankasem
liliankasem previously approved these changes Oct 18, 2024
View reviewed changes
@aishwaryabh aishwaryabh changed the base branch from v4.x to main November 26, 2024 20:25
@aishwaryabh aishwaryabh dismissed liliankasem’s stale review November 26, 2024 20:25

The base branch was changed.

@aishwaryabh aishwaryabh requested a review from a team as a code owner November 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem left review comments

@michaelpeng36 michaelpeng36 Awaiting requested review from michaelpeng36

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

At least 2 approving reviews are required to merge this pull request.

Assignees

@ejizba ejizba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

func start on Linux won't stop upon recieving SIGTERM
4 participants
@beyerleinf @kshyju @liliankasem @ejizba