Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release machinelearningservices microsoft.machine learning services 2025 01 01 preview #32541

Merged
merged 19 commits into from
Feb 14, 2025
Merged

Merge release machinelearningservices microsoft.machine learning services 2025 01 01 preview #32541

merged 19 commits into from
Feb 14, 2025
+61,134 −1

Conversation

ZhidaLiu
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    this branch is a rebase main version of branch release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview to continue contribute on the new API version

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ragovada and others added 16 commits February 10, 2025 10:40
@ragovada @ZhidaLiu
Copy files from preview/2024-10-01-preview
028f83d 
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
@ragovada @ZhidaLiu
Update version to preview/2025-01-01-preview
3d0c0d0 
Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.
@ragovada @ZhidaLiu
Added tag for 2025-01-01-preview in readme file
015bcc6
@ritujhams @ZhidaLiu
Making updates to ActualCapacityInfo for Inference Group Status (#32002)
6d86362 
* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status
@jingyizhu99 @danieljurek @ZhidaLiu
Add quota apis to MFE 20250101-preview (#31885)
cf95f47 
* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (#30893) (#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>
@ragovada @ZhidaLiu
Prettier Gate fixes for Jan 25 preview (#31864)
53051ff 
Co-authored-by: ZhidaLiu <[email protected]>
@liangjason87 @ZhidaLiu
[MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (…
8d92cf5 
…#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json
@vizhur @ZhidaLiu
Update EnvironmentVersion with vulnerabilities object (#32075)
fc8fcd6 
* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json
@marici7274 @ZhidaLiu
Add parent job name (#32106)
ca22f0a 
* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier
@ragovada @ZhidaLiu
Correct tag format (#32141)
134e01c
@karishmadaga @ZhidaLiu
[MFE] Add AAD Auth Modes to Serverless Endpoint (#32100)
d7adf7b 
* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back
@ragovada @ZhidaLiu
Lint diff fixes for Jan 25 preview (#31939)
7a44e98 
* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>
@vikasagrawal-ms @qiaozha @ZhidaLiu
Release distillation changes (#32186)
9dee31c 
* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
@vizhur @ZhidaLiu
Fix typo in vuln contract (#32280)
95b144d
@haoranqian @ZhidaLiu
Add the property irewallPublicIpAddress in ManagedNetworkSettings (#3…
f1747f0 
…2123)
@ZhidaLiu
Fix issue caused by rebase
2ec3c2d
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 10, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 10, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning There is no API change compared with the previous version
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=840e510b8a424768a9e8c2b724b71c11
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=96e0da1ef875464da772f9994410a591
.Net Azure.ResourceManager.MachineLearning https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=2d7c1d84a5184159823f4cac2a5379d4

@ZhidaLiu ZhidaLiu marked this pull request as ready for review February 10, 2025 19:18
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 10, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.MachineLearningServices

This was referenced Feb 10, 2025
Draft
Draft
Draft
@ZhidaLiu
Copy link
Member Author

ZhidaLiu commented Feb 14, 2025 •
edited
Loading

@ZhidaLiu are only examples being updated in the PR ? No Swagger exists today , so why are only examples being updated ?

@ramoka178 There are swagger exist today, I don't understand what you mean only examples in this PR, there are files like mfe.json workspaceRP.json and also the readme fine update in this PR, this PR is trying to create a new API version and all the commit to this branch are going through ARM review process and got ARM reviewer approved individually. so this should be a safe PR to approve.

we also need suppression approve lable as well as we need to suppress some of the lint error that not introduced in this version

@ZhidaLiu ZhidaLiu removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 14, 2025
@ragovada
Copy link
Member

Hi @ramoka178 - Thanks for your time reviewing our PR. As per our conversation during OH this morning, here is the list of the commits (which are already pre-approved by ARM) included in this PR for easy reference:
#32002
#31885
#31864
#32030
#32075
#32106
#32141
#32100
#31939
#32186
#32280
#32123
#32543
#32603

@ramoka178 ramoka178 added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 14, 2025
@ragovada
Merge branch 'main' into merge-release-machinelearningservices-Micros…
5142b42 
…oft.MachineLearningServices-2025-01-01-preview
@ragovada ragovada merged commit 29cdd2f into main Feb 14, 2025
28 of 29 checks passed
@ragovada ragovada deleted the merge-release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview branch February 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragovada ragovada ragovada approved these changes

Assignees
No one assigned
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.