[identity] simplify code to check IMDS availability

[jeremymeng]

The helper prepareRequestOptions() is used once internally in imdsMsi.ts. It is only used to create a request to invoke a response from IMDS endpoint. This PR simplifies the code to remove the { skipMetadataHeader: true, skipQuery: true, } options argument and creates the request directly.

Packages impacted by this PR

@azure/identity

[jeremymeng]

I didn't find the helper useful outside of this file.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[minhanh-phan]

The change looks good to me, seems like a legacy code. I'll defer the approval to @KarishmaGhiya since she approved this change originally here, so she might know more about the context for this

[KarishmaGhiya]

@jeremymeng If we are skipping the query from the request for all scenarios, then how will the client ID / resourceID if set, be passed as part of the IMDS request? We haven't accommodated that scenario under the code refine, right? Am I missing something?

[jeremymeng]

@jeremymeng If we are skipping the query from the request for all scenarios, then how will the client ID / resourceID if set, be passed as part of the IMDS request? We haven't accommodated that scenario under the code refine, right? Am I missing something?

The only use of this helper is to send an invalid request to get an error response quickly. skipQuery: true was passed so no query parameters were added to the url as the whole if (!skipQuery) { } block was not executed. When we remove that block, clientId and resourceId parameters become unused so they are also removed.