Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: incorrect paths for some routes that contain query params #1899

Open
4 tasks done
jhendrixMSFT opened this issue Nov 21, 2024 · 2 comments
Open
4 tasks done

[Bug]: incorrect paths for some routes that contain query params #1899

jhendrixMSFT opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Nov 21, 2024

Describe the bug

For this route.

@route("/{containerName}/{blob}?comp=appendblock")

The sdkMethod.operation.path has an incorrect value: /{containerName}/{blob}?AppendBlob/{containerName}/{blob}?comp=appendblock

Reproduction

Build blob storage tsp https://github.com/Azure/azure-rest-api-specs/blob/feature/blob-tsp/specification/storage/Microsoft.BlobStorage

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@jhendrixMSFT jhendrixMSFT added bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library labels Nov 21, 2024
@jhendrixMSFT jhendrixMSFT changed the title [Bug]: duplicate paths for some routes that contain query params [Bug]: incorrect paths for some routes that contain query params Nov 22, 2024
@tadelesh
Copy link
Member

i could not repro with the spec. could you upgrade to latest version to see it is resolved?

@tadelesh tadelesh self-assigned this Nov 26, 2024
@tadelesh
Copy link
Member

tadelesh commented Nov 26, 2024

Image
from the debug screenshot, the compiler return path is already wrong (see __raw path value). it should not be a tcgc issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants