You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To migrate Compute swagger to TypeSpec, now we split it into several sub service like Compute, Gallery, Disk, Sku, etc. We translate these sub swagger into TypeSpec separately. We currently validate the TypeSpec by checking the SDK API. Later we will need to merge these several sub TypeSpec back into one TypeSpec.
The problem is when we do the splitting, some resource hierarchy information is lost. For example, when we do conversion for DiskRestorePoint in the sub service Disk, we will go through the whole swagger and find there is no parent for this resource. Therefore, DiskRestorePoint will become a resource without a parent in the Typespec. However, its parent and grandparent are actually in the "external" Compute sub service.
Therefore, if we are going to merge these sub services into one spec later, we cannot simply combine them together, we should add this resource relationship information back too!
Don't rely on SDK API comparison to uncover this issue! Since we now don't have getArmResources so we calculate resource information in the generator according to the input swagger. Therefore, using the generated swagger to generate SDK still have correct resource information.
The text was updated successfully, but these errors were encountered:
To migrate Compute swagger to TypeSpec, now we split it into several sub service like Compute, Gallery, Disk, Sku, etc. We translate these sub swagger into TypeSpec separately. We currently validate the TypeSpec by checking the SDK API. Later we will need to merge these several sub TypeSpec back into one TypeSpec.
The problem is when we do the splitting, some resource hierarchy information is lost. For example, when we do conversion for DiskRestorePoint in the sub service Disk, we will go through the whole swagger and find there is no parent for this resource. Therefore, DiskRestorePoint will become a resource without a parent in the Typespec. However, its parent and grandparent are actually in the "external" Compute sub service.
Therefore, if we are going to merge these sub services into one spec later, we cannot simply combine them together, we should add this resource relationship information back too!
Don't rely on SDK API comparison to uncover this issue! Since we now don't have
getArmResources
so we calculate resource information in the generator according to the input swagger. Therefore, using the generated swagger to generate SDK still have correct resource information.The text was updated successfully, but these errors were encountered: