Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a hasEtag in an operation exposed by TCGC #1915

Open
lmazuel opened this issue Nov 26, 2024 · 0 comments
Open

Create a hasEtag in an operation exposed by TCGC #1915

lmazuel opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@lmazuel
Copy link
Member

lmazuel commented Nov 26, 2024

Feels like right now, we require emitters to manually sniff header names to decided if an operation required AzureCore MatchCondition. That's how I read that Python code for instance:

https://github.com/microsoft/typespec/blob/eaa71125e74cb867ba4fa69eb28f4e091e8a33d5/packages/http-client-python/generator/pygen/preprocess/__init__.py#L299-L330

I believe it would be beneficial, if we were to raise up that computation to TCGC operation type, to simplify emitter work to implement (in particular here C++ emitter).

Thoughts?

@lmazuel lmazuel added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants