-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back middle-dot as function composition for backward compatibility #737
Comments
Can we support this without changing back to ISO 8859-1? I recall prior to this change, editing Prelude.bs was rather annoying. My editor insisted on changing the file encoding whenever I saved, which caused any appearance of U+B7 to get corrupted. |
See #601, for reference. |
Yes, we can support this without changing back to ISO 8859-1. The middle dot exists in unicode, and can be encoded in UTF-8. |
What about adding a flag to BSC to specify additional "prelude" libraries, that are automatically imported. Then you could define the middle-dot compose operator in a file BSC already has a hidden flag Would that satisfy your need to support an old codebase without having to make manual edits to many files? |
I've encountered legacy code that uses middle-dot as function composition (someone had created a forked version of some of the BSC standard libraries), and it would be nice to still be able to compile that without too much trouble.
This commit 369041e changed all instances of middle-dot (U+B7) to ring-operator (U+2218). But we didn't have to stop supporting middle-dot; we can support both middle-dot and ring-operator both for function composition.
(
iconv
can handle converting from ISO 8859-1 to UTF-8.)The text was updated successfully, but these errors were encountered: