Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do our finished material models go? #54

Open
srosenbu opened this issue May 27, 2024 · 0 comments
Open

Where do our finished material models go? #54

srosenbu opened this issue May 27, 2024 · 0 comments

Comments

@srosenbu
Copy link
Member

The design decision behind the new main branch was among other things to differentiate between the interface of a model and its implementation such that you don't need to have a model included in the repo to actually use it. Therefore, we didn't want to have a large collection of models in the src directory. This is great for development, since a developer of a new model does not need to open a PR in order to have a model that they can use with a solver that has been written for fenics-constitutive.

However, at some point it would be useful to have a collection of finished models that can just be installed and imported in python. Currently there are some models in the examples directory which are all tested, but you can't from models import MisesPlasticity.

I still think it is a good idea to have the strong seperation between the interfaces and the actual models, so should we just open a new repo for a model collection or try to have two packages in the same repository (Monorepo example)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant