Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApsPssShutter and/or ShutterBase could support kwargs to define open_value and close_value #1037

Open
prjemian opened this issue Oct 31, 2024 · 1 comment
Labels
task Something to be done.
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Oct 31, 2024

Note that the ApsPssShutter support uses a fixed value of 1 when writing to then open:

self.open_signal.put(1)

and close PV:
self.close_signal.put(1)

The base class supports custom values for self.open_value and self.close_value:

open_value = 1 # value of "open"
close_value = 0 # value of "close"

The base class constructor does not provide kwargs to set these. Might be a good addition, otherwise need to set shutter.close_value=1 once the shutter object is created.

Originally posted by @prjemian in #1036 (comment)

@prjemian prjemian added the task Something to be done. label Oct 31, 2024
@prjemian prjemian added this to the 1.7.2 milestone Oct 31, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Oct 31, 2024

Since the open() and close() methods perform both set and reset, need to add open_reset_value and close_reset_value to replace fully these assumptions of 0 and 1:

if self.open_signal.get() == 1:
self.open_signal.put(0)

if self.close_signal.get() == 1:
self.close_signal.put(0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Something to be done.
Projects
None yet
Development

No branches or pull requests

1 participant