Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of reference/license info makes it hard to see figure caption text #71

Open
kphunter opened this issue Jun 29, 2018 · 1 comment

Comments

@kphunter
Copy link
Contributor

kphunter commented Jun 29, 2018

IMHO, it's difficult to see the figure caption text when it is positioned above <figcaption> text:

reference-current

Given that HTML5 spec stipulates that <figcaption>s should be either the very first element or the very last element within a <figure> element, I propose we move the <footer><small> block into the very end of the <figcaption> (prepend </figcaption> with the license/reference content) like:

<figure class="image"><img src="assets/6.jpeg" alt="">
  <figcaption>
    <p>Peripheral Edema</p>
    <footer><small>Reference: James Heilman. (2018, May 14). Pitting edema during and after the application of pressure to the skin [Online image]. Retrieved from <a href="https://en.wikipedia.org/wiki/Edema">https://en.wikipedia.org/wiki/Edema</a></small></footer>
 </figcaption>
</figure>

so that it might look like this:

reference-good

We will also need to double-check that Sugar Suite .reference/.license styling isn't overwritten by .figcaption styling.

@kphunter
Copy link
Contributor Author

Another example of a hard-to-read caption (because of reference/license text):

license-text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant