Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading use of "URL" when asking for base domain name during install_bootstrap #106

Open
brainstorm opened this issue Jul 28, 2017 · 0 comments

Comments

@brainstorm
Copy link
Member

A URL includes a protocol or "scheme" in front of a domain name, i.e http.

If a correct URL is supplied during install_bootstrap, no warning nor error will show up until the nginx server will fail to serve requests since a templating substition for s/__my.example.com__/http://my.domain.com/ will garble the result... leading to a 503 Service temporarily unavailable error.

A possible solution would be to either chop the scheme (http:// part of the URL) on install_bootstrap or use other characters in the regexp to delimit origin and dest, i.e:

sed -ie s#__my.example.com__#http://my.domain.com/#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant