Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dedicated transports #3164

Open
4 tasks
nstephenh opened this issue Mar 29, 2024 · 3 comments
Open
4 tasks

Clean up dedicated transports #3164

nstephenh opened this issue Mar 29, 2024 · 3 comments

Comments

@nstephenh
Copy link
Contributor

nstephenh commented Mar 29, 2024

  • Make all dedicated transports a unit with a model in them. This will make new recruit display much better.
  • Ensure that all units that can take a dedicated transport don't have any "number of models" that checks "and all child selections"
  • Consider moving common dedicated transports to a shared selection entry group? But might not be able to then count number of models in parent easily

Units that are having issues with dedicated transports:

  • Mortus Poisoners
@Mayegelt
Copy link
Contributor

I think the 3rd option has been talked over before, but an issue of some RoW or inconsistencies in who gets what, when was to much of an issue to code it out without it looking like a horrible mess, while still keeping it compatible with BSData Editor (and as such could stop it working with other programmes that use the data).

@nstephenh
Copy link
Contributor Author

Does anyone remember why we set some of the dedicated transport hides are set both on the link and on the entry itself? I'm assuming this was just an oversight
image

@Mayegelt
Copy link
Contributor

Mayegelt commented Aug 8, 2024

Does anyone remember why we set some of the dedicated transport hides are set both on the link and on the entry itself? I'm assuming this was just an oversight image

I assume that was the case that some were done twice. It might be because some were done when we were doing it one way, then they were done a different way later on.
If you can make a file check or whatever to find all the dedicated transports that have hidden links in them as well as hidden links in the linked entry, then we can probably filter that better.
We could as suggested above make an omni entry for dedicated transports as a link, but just put the ones that hide for X but not for Y unit with the same restrictions into the link with a "Ancestor is XXX unit" thing now my crusader to get BSEditor compatibility is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants