Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue processing SubModuleOverrides if neither Regex text nor Replacement field were found #21

Open
artifixer opened this issue May 30, 2022 · 0 comments
Assignees

Comments

@artifixer
Copy link
Member

Currently SubModuleOverrides stops processing with non-blocking error if Replacement text is empty for any overrides. This happens even of there when searched text was not found in the SubModule.xml and leads to the faulty SubModule.xml generation.

Suggested fixes:

  1. Make build fail with error if searched text was found in the SubModule.xml, but Replacement text is empty.
  2. Ignore cases where Replacement text was empty if there were no searched text entrances in the SubModule.xml. Ensure that all other SubModuleOverrides will be processed.
@Aragas Aragas self-assigned this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants