You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We had a user today claim our day 21 daily rewards infinitely. The issue was that on day 21 we added $2,500 to the balance of the user as reward, but we also gave him Cosmetic Coins from the plugin "ProCosmetics". Turns out ProCosmetics failed to load today on the server, so NDailyRewards couldn't pass the command to ProCosmetics to give the user the cosmetic coins, this resulted in the user being able to infinite claim day 21 rewards and receive everything.
To Reproduce
Install NDailyRewards (latest version)
Make a config in ndailyrewards that includes a command from another plugin.
Disable the other plugin or make it not load
You will be able to infinite claim the rewards
Expected behaviour
This shouldn't happen, I know this is a rare circumstance, but it would be better if ndailyreward should either mark the day as claimed or give an error if the command can't be ran, instead of allowing the player to infinite claim the day.
Server Implementation
Paper
Server Version
1.21.1
Describe the bug
We had a user today claim our day 21 daily rewards infinitely. The issue was that on day 21 we added $2,500 to the balance of the user as reward, but we also gave him Cosmetic Coins from the plugin "ProCosmetics". Turns out ProCosmetics failed to load today on the server, so NDailyRewards couldn't pass the command to ProCosmetics to give the user the cosmetic coins, this resulted in the user being able to infinite claim day 21 rewards and receive everything.
To Reproduce
Expected behaviour
This shouldn't happen, I know this is a rare circumstance, but it would be better if ndailyreward should either mark the day as claimed or give an error if the command can't be ran, instead of allowing the player to infinite claim the day.
Screenshots / Videos
No response
Error log (if applicable)
https://pastes.dev/qKdsCQ5iDi
NDailyRewards Version
NDailyRewards version 3.1.0
Checklist
Anything else?
Day 21 config:
The action that fails to run is - "[console] procosmetics give coins 575" because the plugin didn't load on server startup.
'21': position: 34 lore: - '&7Come back every day to' - '&7receive more rewards!' - '' - '&fʀᴇᴡᴀʀᴅs:' - ' &8- &6$2,500' - ' &8- &61x Epic Crate Key' - ' &8- &6576 Cosmetic Coins' - ' &8- &61x Daily Login Token' actions: - "[console] discordsrv bcast ##1315831381930151977 **<player>** claimed the daily reward: **Day #21**" - "[console] eco give <player> 2500" - "[console] procosmetics give coins<player> 575" - "[console] ecrates key give <player> epic 1" - "[console] voucher give DailyLoginToken 1 <player>" - "[message] &8[&2&l•&8] &a&lʀᴇᴡᴀʀᴅs &8→ &fYou have claimed your reward!" - "[sound] ENTITY_EXPERIENCE_ORB_PICKUP:1:1"
The text was updated successfully, but these errors were encountered: