Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDailyRewards can be exploited if a command can't be ran due to a plugin disabled #110

Open
2 tasks done
articbloom opened this issue Dec 10, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@articbloom
Copy link

Server Implementation

Paper

Server Version

1.21.1

Describe the bug

We had a user today claim our day 21 daily rewards infinitely. The issue was that on day 21 we added $2,500 to the balance of the user as reward, but we also gave him Cosmetic Coins from the plugin "ProCosmetics". Turns out ProCosmetics failed to load today on the server, so NDailyRewards couldn't pass the command to ProCosmetics to give the user the cosmetic coins, this resulted in the user being able to infinite claim day 21 rewards and receive everything.

To Reproduce

  1. Install NDailyRewards (latest version)
  2. Make a config in ndailyrewards that includes a command from another plugin.
  3. Disable the other plugin or make it not load
  4. You will be able to infinite claim the rewards

Expected behaviour

This shouldn't happen, I know this is a rare circumstance, but it would be better if ndailyreward should either mark the day as claimed or give an error if the command can't be ran, instead of allowing the player to infinite claim the day.

Screenshots / Videos

No response

Error log (if applicable)

https://pastes.dev/qKdsCQ5iDi

NDailyRewards Version

NDailyRewards version 3.1.0

Checklist

Anything else?

Day 21 config:

The action that fails to run is - "[console] procosmetics give coins 575" because the plugin didn't load on server startup.
'21': position: 34 lore: - '&7Come back every day to' - '&7receive more rewards!' - '' - '&fʀᴇᴡᴀʀᴅs:' - ' &8- &6$2,500' - ' &8- &61x Epic Crate Key' - ' &8- &6576 Cosmetic Coins' - ' &8- &61x Daily Login Token' actions: - "[console] discordsrv bcast ##1315831381930151977 **<player>** claimed the daily reward: **Day #21**" - "[console] eco give <player> 2500" - "[console] procosmetics give coins<player> 575" - "[console] ecrates key give <player> epic 1" - "[console] voucher give DailyLoginToken 1 <player>" - "[message] &8[&2&l•&8] &a&lʀᴇᴡᴀʀᴅs &8→ &fYou have claimed your reward!" - "[sound] ENTITY_EXPERIENCE_ORB_PICKUP:1:1"

@NONPLAYT NONPLAYT added this to the NDailyRewards 3.2.0 milestone Dec 12, 2024
@NONPLAYT NONPLAYT added the bug Something isn't working label Dec 12, 2024
@NONPLAYT
Copy link
Member

Hello! This will be checked and fixed in version 3.2.0

@NONPLAYT NONPLAYT self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants