From ebbb53c5ae4371c02d717ba1ff896720c1c55e30 Mon Sep 17 00:00:00 2001 From: rcmerci Date: Thu, 12 Dec 2024 17:40:14 +0800 Subject: [PATCH] perf: reduce str & pr-str calls --- src/main/frontend/components/property/value.cljs | 2 +- src/main/frontend/state.cljs | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/main/frontend/components/property/value.cljs b/src/main/frontend/components/property/value.cljs index 9fc963b597c..03075ca1cc8 100644 --- a/src/main/frontend/components/property/value.cljs +++ b/src/main/frontend/components/property/value.cljs @@ -756,7 +756,7 @@ state)} [state value block property page-cp] (when value - (if (state/sub-async-query-loading value) + (if (state/sub-async-query-loading (:block/uuid value)) [:div.text-sm.opacity-70 "loading"] (if-let [v-block (db/sub-block (:db/id value))] (let [class? (ldb/class? v-block) diff --git a/src/main/frontend/state.cljs b/src/main/frontend/state.cljs index b8b485eb31e..6badacd5054 100644 --- a/src/main/frontend/state.cljs +++ b/src/main/frontend/state.cljs @@ -2286,10 +2286,11 @@ Similar to re-frame subscriptions" (defn sub-async-query-loading [k] - (assert (some? k)) - (rum/react - (r/cached-derived-atom (:db/async-query-loading @state) [(get-current-repo) ::async-query (str k)] - (fn [s] (contains? s (str k)))))) + (assert (or (string? k) (uuid? k))) + (let [k* (str k)] + (rum/react + (r/cached-derived-atom (:db/async-query-loading @state) [(get-current-repo) ::async-query k*] + (fn [s] (contains? s k*)))))) (defn clear-async-query-state! []