From 01f522eabd1356171dd5fc7ba5e7b2c090afa26b Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Wed, 20 Nov 2024 08:57:17 +0530 Subject: [PATCH 1/7] [Rahul] | Fix. Node - Runner Incompatability --- .github/workflows/npm-publish.yml | 5 +++-- .github/workflows/validate-pr.yml | 9 ++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index f83b4472..4f48ffbe 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -16,11 +16,12 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS 10.19.0 - uses: actions/setup-node@v3 + - name: Set up Node JS v12.13.0 + uses: actions/setup-node@v4 with: node-version: 12.13.0 registry-url: 'https://registry.npmjs.org' + architecture: 'x64' - run: yarn cache clean - name: Install dependencies run: brew install automake autoconf libtool dpkg pkgconfig nasm libpng diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index ee864250..105e1540 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -2,7 +2,9 @@ name: Validate PR for Bahmni Form Controls on: pull_request: - branches: [ master ] + branches: + - master + - 'fix-node' types: [ opened, synchronize, reopened ] workflow_dispatch: @@ -13,11 +15,12 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS 10.19.0 - uses: actions/setup-node@v3 + - name: Set up Node JS v12.13.0 + uses: actions/setup-node@v4 with: node-version: 12.13.0 registry-url: 'https://registry.npmjs.org' + architecture: 'x64' - run: yarn cache clean - name: Install dependencies run: brew install automake autoconf libtool dpkg pkgconfig nasm libpng From ee2cd99fb55d7e5dfeafb17fafe494bea9e1cb15 Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Wed, 20 Nov 2024 09:08:44 +0530 Subject: [PATCH 2/7] [Rahul] | Fix. Bump Node Version 12.13.0 -> 14.2.0 --- .github/workflows/npm-publish.yml | 4 ++-- .github/workflows/validate-pr.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 4f48ffbe..10fd0691 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -16,10 +16,10 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v12.13.0 + - name: Set up Node JS v14.2.0 uses: actions/setup-node@v4 with: - node-version: 12.13.0 + node-version: 14.2.0 registry-url: 'https://registry.npmjs.org' architecture: 'x64' - run: yarn cache clean diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 105e1540..4ccff7f1 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -15,10 +15,10 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v12.13.0 + - name: Set up Node JS v14.2.0 uses: actions/setup-node@v4 with: - node-version: 12.13.0 + node-version: 14.2.0 registry-url: 'https://registry.npmjs.org' architecture: 'x64' - run: yarn cache clean From 0660866a35ecaa61ff426a6984482e949ace1272 Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Wed, 20 Nov 2024 10:52:34 +0530 Subject: [PATCH 3/7] [Rahul] | Fix. Bump Node Version 14.2.0 -> 14.15.1 --- .github/workflows/npm-publish.yml | 4 ++-- .github/workflows/validate-pr.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 10fd0691..2f01aff7 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -16,10 +16,10 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v14.2.0 + - name: Set up Node JS v14.15.1 uses: actions/setup-node@v4 with: - node-version: 14.2.0 + node-version: 14.15.1 registry-url: 'https://registry.npmjs.org' architecture: 'x64' - run: yarn cache clean diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 4ccff7f1..1655fec0 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -15,10 +15,10 @@ jobs: steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v14.2.0 + - name: Set up Node JS v14.15.1 uses: actions/setup-node@v4 with: - node-version: 14.2.0 + node-version: 14.15.1 registry-url: 'https://registry.npmjs.org' architecture: 'x64' - run: yarn cache clean From a1c7674353784a778d8b5fa53e25d735cb14ab49 Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Wed, 20 Nov 2024 11:03:29 +0530 Subject: [PATCH 4/7] [Rahul] | Fix. Switch Runner macos -> ubuntu --- .github/workflows/npm-publish.yml | 7 +++---- .github/workflows/validate-pr.yml | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 2f01aff7..c8996d10 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -12,16 +12,15 @@ on: jobs: build: - runs-on: macos-latest + runs-on: ubuntu-latest steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v14.15.1 + - name: Set up Node JS v14.2.0 uses: actions/setup-node@v4 with: - node-version: 14.15.1 + node-version: 14.2.0 registry-url: 'https://registry.npmjs.org' - architecture: 'x64' - run: yarn cache clean - name: Install dependencies run: brew install automake autoconf libtool dpkg pkgconfig nasm libpng diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 1655fec0..2f8c413d 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -11,16 +11,15 @@ on: jobs: build: - runs-on: macos-latest + runs-on: ubuntu-latest steps: - name: Checkout the code uses: actions/checkout@v3 - - name: Set up Node JS v14.15.1 + - name: Set up Node JS v14.2.0 uses: actions/setup-node@v4 with: - node-version: 14.15.1 + node-version: 14.2.0 registry-url: 'https://registry.npmjs.org' - architecture: 'x64' - run: yarn cache clean - name: Install dependencies run: brew install automake autoconf libtool dpkg pkgconfig nasm libpng From b8daf13f73d2a688e5b969d80c4f3b7249425765 Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Fri, 22 Nov 2024 08:12:33 +0530 Subject: [PATCH 5/7] [Rahul] | Fix. Switch Runner macos-latest -> macos-13 --- .github/workflows/npm-publish.yml | 2 +- .github/workflows/validate-pr.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index c8996d10..58e1c76e 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -12,7 +12,7 @@ on: jobs: build: - runs-on: ubuntu-latest + runs-on: macos-13 steps: - name: Checkout the code uses: actions/checkout@v3 diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 2f8c413d..da5a8ae8 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -11,7 +11,7 @@ on: jobs: build: - runs-on: ubuntu-latest + runs-on: macos-13 steps: - name: Checkout the code uses: actions/checkout@v3 From 0512a77dd212a36baecfd5f258914b050bec345b Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Fri, 22 Nov 2024 08:17:40 +0530 Subject: [PATCH 6/7] [Rahul] | Fix. Remove Branch Trigger --- .github/workflows/validate-pr.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index da5a8ae8..09e301a9 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -4,7 +4,6 @@ on: pull_request: branches: - master - - 'fix-node' types: [ opened, synchronize, reopened ] workflow_dispatch: From 18abbe30ed16f46b17a7221582981f26ed9309f5 Mon Sep 17 00:00:00 2001 From: Rahul Ramesh Date: Fri, 22 Nov 2024 08:23:19 +0530 Subject: [PATCH 7/7] [Rahul] | Fix. Revert Branch Trigger Changes --- .github/workflows/validate-pr.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 09e301a9..6acbcfe7 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -2,8 +2,7 @@ name: Validate PR for Bahmni Form Controls on: pull_request: - branches: - - master + branches: [ master ] types: [ opened, synchronize, reopened ] workflow_dispatch: