Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SketchingOperator and SketchingDistribution concepts #84

Closed
rileyjmurray opened this issue Apr 11, 2024 · 3 comments
Closed

Define SketchingOperator and SketchingDistribution concepts #84

rileyjmurray opened this issue Apr 11, 2024 · 3 comments

Comments

@rileyjmurray
Copy link
Contributor

PR #83 introduces a SparseMatrix concept for templating and documentation purposes. I want to define similar concepts for sketching operators and sketching distributions, but I don't want doing that to hold up the PR. So I'm making a note here to follow-up.

@rileyjmurray
Copy link
Contributor Author

Using concepts requires C++20 or higher. Some compilers support most of C++20 but conspicuously lack support for concepts. This makes it more of a pain than one might expect to build RandBLAS when working with such compilers. I noticed an interesting way around this in the Fast Matrix Market project; see https://github.com/alugowski/fast_matrix_market/blob/b6172c96ef73d16b2c10917373bacec1a7583a31/include/fast_matrix_market/app/array.hpp#L11-L40.

@rileyjmurray
Copy link
Contributor Author

Will be added in PR #104.

@rileyjmurray
Copy link
Contributor Author

Completed in #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant