Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused parameters in HQRRP #70

Open
rileyjmurray opened this issue Apr 24, 2024 · 1 comment
Open

unused parameters in HQRRP #70

rileyjmurray opened this issue Apr 24, 2024 · 1 comment

Comments

@rileyjmurray
Copy link
Contributor

rileyjmurray commented Apr 24, 2024

I noticed the following compiler warnings about unused parameters in HQRRP in the GPU branch. The same issues probably show up on main as well.

/home/jonathan/RandNLA-dev/RandLAPACK/RandLAPACK/../RandLAPACK/drivers/rl_hqrrp.hh:578:1: warning: unused parameter ‘use_cholqr’ [-Wunused-parameter]
  577 | int64_t NoFLA_QRPmod_WY_unb_var4(
      |                          ~~~~~~~~
  578 |     int64_t use_cholqr, int64_t pivoting, int64_t num_stages,
      | ^   ~~~~~~
/home/jonathan/RandNLA-dev/RandLAPACK/RandLAPACK/../RandLAPACK/drivers/rl_hqrrp.hh:578:21: warning: unused parameter ‘pivoting’ [-Wunused-parameter]
  578 |     int64_t use_cholqr, int64_t pivoting, int64_t num_stages,
      |             ~~~~~~~~^~~~~~~~
/home/jonathan/RandNLA-dev/RandLAPACK/RandLAPACK/../RandLAPACK/drivers/rl_hqrrp.hh:583:40: warning: unused parameter ‘buff_R’ [-Wunused-parameter]
  583 |     int64_t build_T, T * buff_T, int64_t ldim_T, T* buff_R, int64_t ldim_R, T* buff_D) {
      |                                     ~~~^~~~~~
/home/jonathan/RandNLA-dev/RandLAPACK/RandLAPACK/../RandLAPACK/drivers/rl_hqrrp.hh:583:56: warning: unused parameter ‘ldim_R’ [-Wunused-parameter]
  583 |     int64_t build_T, T * buff_T, int64_t ldim_T, T* buff_R, int64_t ldim_R, T* buff_D) {
      |                                                ~~~~~~~~^~~~~~
/home/jonathan/RandNLA-dev/RandLAPACK/RandLAPACK/../RandLAPACK/drivers/rl_hqrrp.hh:583:67: warning: unused parameter ‘buff_D’ [-Wunused-parameter]
  583 |     int64_t build_T, T * buff_T, int64_t ldim_T, T* buff_R, int64_t ldim_R, T* buff_D) {
      |                                                                ~~~^~~~~~
[ 94%] Linking CXX executable ../bin/RandLAPACK_tests

@TeachRaccooon, please investigate. Is it really okay that these parameters are unused? If so, is there a reason why we shouldn't remove them?

@TeachRaccooon
Copy link
Contributor

@rileyjmurray that's just because I commented out a bunch of stuff in HQRRP for ease of profiling. These warnings are not present on main. We can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants