Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 support? #95

Open
sosherof opened this issue Jun 1, 2023 · 8 comments
Open

PHP 8.2 support? #95

sosherof opened this issue Jun 1, 2023 · 8 comments

Comments

@sosherof
Copy link

sosherof commented Jun 1, 2023

Does this library support PHP 8.2? Has it been given similar attention as bandwidth/php-sdk regarding type hinting?

@ajrice6713
Copy link
Contributor

Hey @sosherof!

I can take a look at replicating what we did for the bandwidth/php-sdk here and getting support for PHP > 8.1 - more to come!

Generally this SDK has not received the same level of support - reason being our goal is to autogenerate these and most of the tooling for that does not support XML APIs. We prioritize adding features for these based on customer need.

@sosherof
Copy link
Author

sosherof commented Jun 1, 2023

Funny enough, my reason for wanting to use your libraries was to avoid the XML as well. Is there any thought on API v3 that uses JSON instead?

@ajrice6713
Copy link
Contributor

No one likes XML - we are working internally to rev this dashboard/numbers API to a new major version that supports JSON, however I dont have an official timeline on that.

@sosherof
Copy link
Author

While I'm here making suggestions and especially if you're considering an API v3, consider collapsing the order status APIs down into one. Right now you must use a completely different endpoint to that check that order status for just about every API call that produces an OrderId. For example, if I import a TN and then want to assign a campaign, I have to wait on the import to COMPLETE. The import order status URL is different from the TnOptionsOrder status URL, etc.

@kkamath-bandwidth
Copy link

Re: json, its a yes, but not right now. So, current goal for v2 is to internationalize (e164 support & 60+ countries) with minimum code change on behalf of our existing customers. I promise to push for JSON support after we finish that development (just trying to not hold unification hostage to this and since XML needs to be supported on old endpoints anyways). Also, the new endpoints we are adding will have JSON, so we are learning incrementally too!

Re: order status, its a maybe Sam. The order is not an ecommerce like order that was intended to be a common thing, but instead an async pattern. Bur, yes I am sure there is scope for improvement here. We can look into this more during JSON support,

@ajrice6713
Copy link
Contributor

@sosherof i know its been a while - I just updated our tests to run on 8.0 -> 8.3 and everything seems to be passing if you would like to check v4.2.2 and confirm!

@sosherof
Copy link
Author

Is v4.2.2 the current release? README says 3.3.2. Regardless, if the minimum supported version of PHP is now 8.0, it'll be a moment before I can test as I'll need to setup a test site to run only on the dev server (prod server is still running PHP 7.2).

@ajrice6713
Copy link
Contributor

ajrice6713 commented Jul 19, 2024

Yes - I can get that readme updated - 4.2.2 is the current version - you can see our releases here.

I believe 7.2 should still be supported - I have dropped it from our tests because it is EOL however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants