Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need linting #9

Closed
Beasta opened this issue Dec 21, 2021 · 14 comments · May be fixed by #11
Closed

We need linting #9

Beasta opened this issue Dec 21, 2021 · 14 comments · May be fixed by #11

Comments

@Beasta
Copy link
Owner

Beasta commented Dec 21, 2021

you'll need to create a branch called linting that will have two commits.

The first commit will implement the airbnb ESLint according to the guidelines here

The second commit will bring the codebase into compliance with the standard

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.0199 ETH (79.84 USD @ $4012.28/ETH) attached to it.

@mindsgn
Copy link
Contributor

mindsgn commented Dec 21, 2021

Hi @Beasta made the first PR here: #10

@biendeveloper biendeveloper mentioned this issue Dec 21, 2021
@Beasta
Copy link
Owner Author

Beasta commented Dec 21, 2021

Hi @Beasta made the first PR here: #10

@mindsgn is @biendeveloper your account as well? the link to #10 doesn't have two commits as originally laid out in the issue

@mindsgn
Copy link
Contributor

mindsgn commented Dec 21, 2021

no @blendeveloper is not my account, I will be making second commit in a few minutes.

@mindsgn
Copy link
Contributor

mindsgn commented Dec 21, 2021

@Beasta made the second push on: #10

@mindsgn
Copy link
Contributor

mindsgn commented Dec 21, 2021

please let me know if there is anything else you would like to change.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.0199 ETH (80.02 USD @ $4000.85/ETH) has been submitted by:


@mindsgn
Copy link
Contributor

mindsgn commented Dec 23, 2021

@Beasta, have you had a look?.

@mindsgn
Copy link
Contributor

mindsgn commented Dec 24, 2021

hi @Beasta just fixed merge issues: #10 , please check and get back to me please.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 11 months from now.
Please review their action plans below:

1) mindsgn has started work.

I will implement the airbnb ESLint according to the guidelines here and I will bring the codebase into compliance with the standard.

Learn more on the Gitcoin Issue Details page.

@Beasta
Copy link
Owner Author

Beasta commented Dec 24, 2021

hi @Beasta just fixed merge issues: #10 , please check and get back to me please.

closing this out. payout here -
https://etherscan.io/tx/0x20c8b1acfac4e6910f0c14ddccb0433ab8794074446d921385a4340221048011

@Beasta Beasta closed this as completed Dec 24, 2021
@mindsgn
Copy link
Contributor

mindsgn commented Dec 24, 2021

thank you @Beasta

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.0199 ETH (82.58 USD @ $4129.18/ETH) attached to this issue has been approved & issued to @mindsgn.

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.0199 ETH (82.58 USD @ $4129.18/ETH) attached to this issue has been approved & issued to @mindsgn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants