Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo still maintained? #77

Closed
raing3 opened this issue Oct 19, 2021 · 3 comments
Closed

Is this repo still maintained? #77

raing3 opened this issue Oct 19, 2021 · 3 comments

Comments

@raing3
Copy link
Contributor

raing3 commented Oct 19, 2021

Was looking at submitting a PR to allow this package to be installed on PHP8.

There are some dependencies however (particularly dev ones) that can't be installed with PHP8+their current constraint. This makes it not easily possible to run the automated test suite/code quality tools against PHP8. The ones I've found in particular which cause issues are:

Questions:

  1. Are these repositories maintained? If I were to submit some PRs are they likely to be reviewed/merged/made available via Packagist?
  2. Would there be any objection to changing the code quality tools being used so the dependency on Symfony2-coding-standard can be removed. Perhaps using a different, better maintained phpcs ruleset from someone else, switching to/adding other tools: phpstan, php-cs-fixer, etc.

There are also some other changes I would like to submit PRs for so we can remove some custom stuff we've done in private repos:

  • Config for a prefix to prepend to all metric names.
  • Config for an array of tags to add to all metrics.
  • Custom metric format (relating to Alternative tagging strategies are not supported Statsd#24).
  • Option to opt-particular routes out of emiting the base metrics (... this is maybe a bit more case specific so don't know I can provide a convincing enough reason for this to be added here - for us it is because we have a health check endpoint which we don't want emitting/skewing the data).

Thanks.

@raing3
Copy link
Contributor Author

raing3 commented Oct 25, 2021

I noticed this bundle today: https://github.com/BedrockStreaming/StatsdTagsPrometheusBundle

We had forked the M6Web/Statsd in 2017 to change the format so we could export to DataDog (and subsequently our internal Prometheus instance).

Feels like the existence of BedrockStreaming/StatsdTagsPrometheusBundle creates some unncessary fragmentation/additional maintenance requirements. Maybe one should be deprecated/abandoned in favour of the other, and add desirable features that don't exist in 1 to the other.

The structure of BedrockStreaming/Statsd+BedrockStreaming/StatsdBundle is probably more friendly to others looking to make use of the code (since it can be manually integrated with other frameworks easier without requiring Symfony)... but StatsdTagsPrometheusBundle seems at least a bit better maintained right now.

Any thoughts/plans with this @jdecool / @Oliboy50?

@Oliboy50
Copy link
Member

Hello @raing3 👋

Indeed BedrockStreaming/StatsdTagsPrometheusBundle is a bit more maintained right now because this is the one we're using internally. BedrockStreaming/Statsd+BedrockStreaming/StatsdBundle were what we used internally before we migrate to Prometheus.

Since BedrockStreaming is a company, our main goal in the open source community is to find or build tools that make our life easier in this company. Therefore, it's hard for us to maintain the tools that we don't use anymore (in this case, we may either merge contributions from other folks in a best-effort way, or simply mark our unused repositories as "Deprecated" and let the community fork them if they need to).

We are actually thinking about what will be the future of this repository (To deprecate it or to maintain it in a best-effort way), but my feeling is that you shouldn't expect too much work on this repository right now.

@raing3
Copy link
Contributor Author

raing3 commented Oct 27, 2021

Thanks for the response.

@raing3 raing3 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants