This repository has been archived by the owner on May 4, 2020. It is now read-only.
Extensions frontend [WIP] #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <section class="extensions"> | ||
| {% for extension in extensions %} | ||
| <div class="extension"> | ||
| {{ extension }} |
There was a problem hiding this comment.
We should give more info here:
- a link to the doc of the extension
- a link to the packagist page
|
We also need some navigation to go to this page from the homepage |
|
Yup. |
# Conflicts: # app/AppKernel.php
# Conflicts: # app/AppKernel.php
# Conflicts: # tests/Documentation/SphinxDoc/SphinxBuilderTest.php
# Conflicts: # spec/ExtensionCatalogueSpec.php
| ); | ||
| } | ||
|
|
||
| $this->string = strtolower($string); | ||
| $this->name = strtolower($name); | ||
| $this->type = $data['type']; |
There was a problem hiding this comment.
type is optional in composer.json (omitting it implies library). You should handle it.
… into feature/extensions-frontend
|
Extensions list is ready. Extension details and documentation page is in progress |
| return 'Anonymous'; | ||
| } | ||
|
|
||
| return $package->primaryAuthor()['name']; |
There was a problem hiding this comment.
this will break if someone does not define the author name in their composer.json. You should not trust user input to be valid
|
@stof fixed all your comments. Thanks for still helping me with this one, buddy :) We're close now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.