Implemented step theResponseShouldContainPartialJson #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not check the whole JSON response keys per keys, but only the ones expected. Useful for time changing properties, for example
| $keys = array_intersect($etalonKeys, $actualKeys); | ||
|
|
||
| foreach ($keys as $key) { | ||
| assertArrayHasKey($key, $etalon); |
There was a problem hiding this comment.
this does not make sense. you should assert what the response contain, not what the etalon contains
added 2 commits
January 17, 2014 19:00
|
Hey @stof please check my last commit, hope this is ok now |
| foreach ($expected as $key => $value) { | ||
| assertArrayHasKey($key, $actual); | ||
| if (is_array($value)) { | ||
| $this->assertArrayPartiallyEquals($expected[$key], $actual[$key]); |
There was a problem hiding this comment.
you need to assert that $actual[$key] is an array before calling the method to avoid a fatal error on the typehint
Added comments
|
Hello @stof sorry for the delay to fix this I added assertions to avoid the fatal errors, does it look good ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not check the whole JSON response keys per keys, but only the ones expected.
Useful for time changing properties, for example
Probably like #47