Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of QoS for RosTopicSubNode and RosTopicPubNode #14

Open
PymZoR opened this issue May 27, 2023 · 1 comment
Open

Allow override of QoS for RosTopicSubNode and RosTopicPubNode #14

PymZoR opened this issue May 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@PymZoR
Copy link

PymZoR commented May 27, 2023

Users should have a mechanism to override QoS when subscribing / publishing for topics.
@facontidavide would you prefer this to be done over the blackboard, at compilation time in the derived class, or allowing both (like for the topic name ?)

I have a local version at compile time, but since the subscriber / publisher are created in the constructor, I had to move the initialization part in a public function that take an rclcpp::QoS parameter. This add a bit of boilerplate, as the end user has to call this function in the constructor of it's derived class. If this seems sufficient to you, I can create a PR.

Thanks for this amazing library,
Cheers

@facontidavide facontidavide self-assigned this Aug 24, 2023
@facontidavide facontidavide added the enhancement New feature or request label Aug 24, 2023
@GregoryLeMasurier
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants