Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some players cannot get offline vote rewards #1393

Open
pjindras opened this issue Nov 8, 2024 · 34 comments
Open

Some players cannot get offline vote rewards #1393

pjindras opened this issue Nov 8, 2024 · 34 comments
Labels
Possible Bug Something which could be a possible bug

Comments

@pjindras
Copy link

pjindras commented Nov 8, 2024

Versions
6.17.2

Describe the bug
Some players, only some -> premium uuid for example D3limiter doesnt get reward for offline voting.
But votifier proceeds the vote correctly with name D3limiter, but voting plugin doesnt save the reward into db.

To Reproduce
Steps to reproduce the behavior:
I dont know, there are many players, which works fine and a few, with this problem.

Expected behavior
All should be fine.

Screenshots/Configs
I can send all you need / want.

Additional context
I have offline mode server, uuid is correct in db.

@pjindras pjindras added the Possible Bug Something which could be a possible bug label Nov 8, 2024
@BenCodez
Copy link
Owner

BenCodez commented Nov 8, 2024

Send your config and log on vote

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

And this is how it should look like when player logs in and receives offline rewards: https://mclo.gs/RCa4y35

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

and even if he voted 6 times today, its empty in db
image

@BenCodez
Copy link
Owner

BenCodez commented Nov 8, 2024

Are you using a proxy setup?

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

I use velocity, but I use voting plugin only on backend server, it it worked so well for me for a long time

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

because with Voting plugin on proxy I had a lot of those issues, but I have voting only on 1 backend server, so that helped me

@BenCodez
Copy link
Owner

BenCodez commented Nov 8, 2024

Well, not exactly sure how you have your setup with UUIDs, going to be hard to troubleshoot, since uuids all don't match, even with the proper online uuid

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

yes, I use full offline server, so all uuids are offline mode

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

but plugin created user with correct uuid (same as luckperms and others have) in db and it knows that player was logged in in the logs

@BenCodez
Copy link
Owner

BenCodez commented Nov 8, 2024

The UUIDs you have are online mode UUIDs

And according to the log the uuids are different then what's in the table

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

I'm a little confused :D
but
correct uuid should be 61b6df8e-e96c-460d-81d9-f82af42630a9

it is that which is in voting plugin db, in luckperms and other plugins

@BenCodez
Copy link
Owner

BenCodez commented Nov 8, 2024

Are you on the latest version? What does this do? https://bencodez.com/job/VotingPlugin/

@pjindras
Copy link
Author

pjindras commented Nov 8, 2024

I use latest release, ok I will try latest build.

@pjindras
Copy link
Author

pjindras commented Nov 9, 2024

Latest build has the same issue, these days there are more players with the same issue, all of them original mc accounts with fastlogin. Please help me what to do.

@BenCodez
Copy link
Owner

BenCodez commented Nov 9, 2024

I'm not really sure what's going on. Not really sure if there is much I can do.

Have more logs of it not working with debug?

@pjindras
Copy link
Author

pjindras commented Nov 9, 2024

Here is full debug, players name is D3limiter but it is broken for more players with fastlogin enabled
Log.txt

@pjindras
Copy link
Author

pjindras commented Nov 9, 2024

UUID should be 61b6df8e-e96c-460d-81d9-f82af42630a9 but this is strange this part:

Sat, 9 Nov 2024 21:03:Debug: Processing PlayerVoteEvent: D3limiter/Czech-Craft.eu Sat, 9 Nov 2024 21:03:Developer Debug: Caching ad0b17cc-56d9-3651-94ae-f95a7c4cc55c Sat, 9 Nov 2024 21:03:Developer Debug: MYSQL QUERY: SELECT * FROM novaVotingPlugin_Users WHERE uuid='ad0b17cc-56d9-3651-94ae-f95a7c4cc55c'; Sat, 9 Nov 2024 21:03:Developer Debug: MYSQL QUERY: SELECT * FROM novaVotingPlugin_Users WHERE uuid='ad0b17cc-56d9-3651-94ae-f95a7c4cc55c';

@BenCodez
Copy link
Owner

BenCodez commented Nov 9, 2024 via email

@pjindras
Copy link
Author

pjindras commented Nov 9, 2024

I tried a day ago but it didnt help, but I can try and send debug, can i just reload the plugin when switching the online mode to false?

@BenCodez
Copy link
Owner

BenCodez commented Nov 9, 2024 via email

@pjindras
Copy link
Author

pjindras commented Nov 9, 2024

ok, than i need to wait until tomorrow, because I have peak now this time

@pjindras
Copy link
Author

it is the same problem

@pjindras
Copy link
Author

see this debug log, https://mclo.gs/63DgOLd it is with online mode to false

@pjindras
Copy link
Author

pjindras commented Nov 10, 2024

but it must be some bug, the plugin knows correct UUDI (61b6df8e-e96c-460d-81d9-f82af42630a9) in lot of operations, but in some cases it takes wrong one (ad0b17cc-56d9-3651-94ae-f95a7c4cc55c)
Log (1).txt

Here is full debug log, I don't have nothing more.

But I can provide anything you need.

@BenCodez
Copy link
Owner

see this debug log, https://mclo.gs/63DgOLd it is with online mode to false

But does this work? VotingPlugin will show a different uuid, but will probably work

but it must be some bug, the plugin knows correct UUDI (61b6df8e-e96c-460d-81d9-f82af42630a9) in lot of operations, but in some cases it takes wrong one (ad0b17cc-56d9-3651-94ae-f95a7c4cc55c) Log (1).txt

Here is full debug log, I don't have nothing more.

But I can provide anything you need.

Either you have multiple entries with that player name in the databsae under different uuids or the server is responding with the wrong uuid.

This is why I don't officially support mixed uuids

@pjindras
Copy link
Author

But how can it happen?

I have for example another player Lilus

She has uuid: 8a453048-4c02-4e32-bd47-e223bbc86f30
This uuid is:

  • player data
  • luckperms
  • jpremium (register + login)
  • every other plugin

In Voting plugin DB she has 2 lines:

image

I dont understand, where and why you use 77d7c7ad-6822-3670-9ffb-ba602ef07b84?
And from where its taken?

Its nonsense, if i have in config: online-mode = false, it should use only the 8a453048-4c02-4e32-bd47-e223bbc86f30 and ignore the second one

@BenCodez
Copy link
Owner

But how can it happen?

I have for example another player Lilus

She has uuid: 8a453048-4c02-4e32-bd47-e223bbc86f30 This uuid is:

  • player data
  • luckperms
  • jpremium (register + login)
  • every other plugin

In Voting plugin DB she has 2 lines:

image

I dont understand, where and why you use 77d7c7ad-6822-3670-9ffb-ba602ef07b84? And from where its taken?

Its nonsense, if i have in config: online-mode = false, it should use only the 8a453048-4c02-4e32-bd47-e223bbc86f30 and ignore the second one

Offline uuid is 77d7c7ad-6822-3670-9ffb-ba602ef07b84. Take a look: https://nuckle.github.io/minecraft-offline-uuid-generator/

It won't match what you have on your server since they are technically online uuids, but votingplugin will always resolve the correct uuid based on the name (that's how offline uuids are made) so within votinplugin it should always match.

This is why I don't like having offline/online players on the same server, it tends to get messy.

Does it work while in offline mode within votingplugin? It would reset all player data but it should work otherwise. May be better with a fresh table so there isn't 2 entries.

@pjindras
Copy link
Author

yes, but when I removed the second one, voting plugin generated it back in db

@pjindras
Copy link
Author

and I am still lost, because online uuid of Lilus for example is e04c4734-60a6-4dd3-9020-7c061e7157a2
Offline as you say is 77d7c7ad-6822-3670-9ffb-ba602ef07b84

So what is 8a453048-4c02-4e32-bd47-e223bbc86f30 which is used everywhere? its some 3rd uuid?

@BenCodez
Copy link
Owner

If votingplugin is set to offline mode it should be using: 77d7c7ad-6822-3670-9ffb-ba602ef07b84

However you should stop the server then remove the entry, since it will cache that uuid/name combo

@BenCodez
Copy link
Owner

Votingplugin will just think the uuid is 77d7c7ad-6822-3670-9ffb-ba602ef07b84 since it's generating them based on the name, since for whatever reason relying on the server to get the uuid isn't all that great

@pjindras
Copy link
Author

ok so there is no way to use 8a453048-4c02-4e32-bd47-e223bbc86f30 in votingplugin -> no possible configuration?

@BenCodez
Copy link
Owner

Doesn't appear possible with your setup at the moment, atleast in a way that is consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug Something which could be a possible bug
Projects
None yet
Development

No branches or pull requests

2 participants