Luxtronik Discovery - wrong content, skipping

[phagemann]

Hello everbody,

im trying to debug the discovery of my heatpump. As mentioned in Discussion 311 it returns None as heatpump model.
Is a similar behavior known?

Using current main branch.
Heatpump: LD9V
Luxtronik: V3.89.5

While doing so, I'm confused about the [...] wrong content, skipping debug message:

2025-01-01 10:18:55.738 DEBUG (MainThread) [custom_components.luxtronik2] Received response from 192.168.3.159 ['2500', '111', '8889', '\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00']
2025-01-01 10:18:55.738 DEBUG (MainThread) [custom_components.luxtronik2] Received response from 192.168.3.159, but with wrong content, skipping

Are the zero-bytes a special feature of my current firmware / heatpump or is it an acceptable behavior?
Could somebody check his discovery? In case it is the intended behavior I would like to suggest following changes:

Looking at:

luxtronik/custom_components/luxtronik/lux_helper.py

Lines 68 to 90 in 9e7f06c

	if res.startswith(LUXTRONIK_DISCOVERY_RESPONSE_PREFIX):
	res_list = res.split(";")
	LOGGER.debug(
	"Received response from %s %s", ip_address, str(res_list)
	)
	try:
	res_port: int | None = int(res_list[2])
	if res_port is None or res_port < 1 or res_port > 65535:
	LOGGER.debug("Response contained an invalid port, ignoring")
	res_port = None
	except ValueError:
	res_port = None
	if res_port is None:
	LOGGER.debug(
	"Response did not contain a valid port number,"
	"an old Luxtronic software version might be the reason"
	)
	results.append((ip_address, res_port))
	LOGGER.debug(
	"Received response from %s, but with wrong content, skipping",
	ip_address,
	)
	continue

The debug in line 86 says we are skipping this device, but essentially we keep using it, as it is returned.
Shouldn't the continue after line 85 be contained at the end of the if block, after the results.append((ip_address, res_port)), as Luxtronik replied with a acceptable discovery response?

 if res.startswith(LUXTRONIK_DISCOVERY_RESPONSE_PREFIX): 
     res_list = res.split(";") 
     LOGGER.debug( 
         "Received response from %s %s", ip_address, str(res_list) 
     ) 
     try: 
         res_port: int | None = int(res_list[2]) 
         if res_port is None or res_port < 1 or res_port > 65535: 
             LOGGER.debug("Response contained an invalid port, ignoring") 
             res_port = None 
     except ValueError: 
         res_port = None 
     if res_port is None: 
         LOGGER.debug( 
             "Response did not contain a valid port number," 
             "an old Luxtronic software version might be the reason" 
         ) 
     results.append((ip_address, res_port)) 
     continue 
 LOGGER.debug( 
     "Received response from %s, but with wrong content, skipping", 
     ip_address, 
 )