You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a lot of functions in aws.py that use get_x (and corresponding calls to y.get_x()) for attributes that should be properties of the class. These should be changed to use the @property decorator and @x.setter (if not readonly).
All internal variables should be prefixed with _ (as in, self._x).
Abstract base classes should have separate files from their derived classes (e.g., AWS implementation of CloudInstance)
Replace string concatenations using + with f-strings
Replace print with logging where possible
The text was updated successfully, but these errors were encountered:
mjd3
changed the title
Use python properties instead of get_x functions
Python style and best practices
May 12, 2022
get_x
functionsget_x
(and corresponding calls toy.get_x()
) for attributes that should be properties of the class. These should be changed to use the@property
decorator and@x.setter
(if not readonly)._
(as in,self._x
).CloudInstance
)+
with f-stringsprint
withlogging
where possibleThe text was updated successfully, but these errors were encountered: