Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in example usage of rlds dataset replayer, and missing example usage of recorder #11

Open
J-HowHuang opened this issue Apr 5, 2024 · 0 comments

Comments

@J-HowHuang
Copy link

Problem Description

In README.md

source install/setup.bash
ros2 run fogros2_rt_x replayer --ros-args -r dataset_name:=$DATASET_NAME 
# replace with yours, e.g. berkeley_fanuc_manipulation

instead of flag -r for remapping, should be -p for passing argument dataset_name

source install/setup.bash
ros2 run fogros2_rt_x replayer --ros-args -p dataset_name:=$DATASET_NAME 
# replace with yours, e.g. berkeley_fanuc_manipulation

Also, I thought the replayer was to used with ros2 bag record command. But @KeplerC told me it should be used with the recorder.

Suggestion

Update README.md:

Run the below commands to start recorder:

source install/setup.bash
ros2 run fogros2_rt_x recorder --ros-args -p dataset_name:=$DATASET_NAME 
# replace with yours, e.g. berkeley_fanuc_manipulation

In the other shell, run replayer to replay your dataset

ros2 run fogros2_rt_x replayer --ros-args -p dataset_name:=$DATASET_NAME 
# replace with yours, e.g. berkeley_fanuc_manipulation

The result ros bag will be stored under ./rosbags/$DATASET_NAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant