-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch does not work on latest version 3.6.1 #506
Comments
I fought with this a lot and found that the pinch gesture is being interpreted as a pan gesture. It only detects the pinch if I start panning first with one finger and then put down the other finger afterwards. Downgrading to 3.5.1 did fix it for me as well. |
I have the same issue: downgrade to 3.6.0 helps. This PR make this issue happened https://github.com/BetterTyped/react-zoom-pan-pinch/pull/484/files |
Same here. |
madare hamatono gaiidam 🙌❤ |
Can confirm that this is the issue. Two tap events happens consecutively when a pinch gesture happens, and the second one triggers the |
What is really confusing is that the demo storybook obviously doesn't use this 3.6.1 version. The storybook version worked on my phone and my app didn't. So I spent hours debugging thinking it must be an issue of my app. |
For anyone, who couldn't resolve it by switching to another versions, take a look at your index.html file, because it can be an additional reason of not working pinch - <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
+ <meta name="viewport" content="width=device-width, user-scalable=no"> Or play with |
Describe the bug
Pinch functionality does not seem to work at all on version 3.6.2, the entire page is zoomed instead of the element. When downgrading to version 3.5.1 it seems to work as expected.
To reproduce
Steps to reproduce the behavior:
Expected behavior
The zoom effect should only be applied to the transform component, not the entire page.
Smartphone (please complete the following information):
Additional context
This issue does not seem to exist on older versions.
The text was updated successfully, but these errors were encountered: