Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a hidden axis is revealed, it is detached from control (reorderable, brushes, etc) #26

Open
BigFatDog opened this issue Jun 26, 2018 · 3 comments
Assignees

Comments

@BigFatDog
Copy link
Owner

BigFatDog commented Jun 26, 2018

@joshhjacobson has discovered this bug in issue #15
Thank @joshhjacobson for the detailed information

Thanks! This seems to have handled all the console errors, and axis reordering is mostly functional. While testing, I noticed a bug where the right-most axis seems to become disconnected from the canvas. You can still interact with all the other axes by dragging them around and brushing, but the right-most one is unresponsive. If you drag another axis toward it, the polylines will adjust accordingly, but the svg axis itself will remain fixed.

show

This was produced using the example above where I start with one axis hidden, and then click the button to 'show' it.

@joshhjacobson
Copy link
Contributor

Hi there,

I recently came across an error that might shed some light on this issue. After calling pc.hideAxis(array) I go to update the chart with pc.render().updateAxes(500). This generates the following error:

screen shot 2018-09-20 at 5 37 57 pm

Which references this line:
screen shot 2018-09-20 at 5 38 47 pm

So the rightmost axis gets 'detached' because it becomes undefined at some point in this process?

@wraseman
Copy link

I believe the issue that @joshhjacobson was running into is because the cars dataset we were using has a column of string data called 'names'. Josh and I were trying to implement some features, like k-means clustering, which perform some operation on the numerical data and the result generates a new column of numerical data. When we inadvertently tried to cluster string and names data, the clustering would work, but the new clustering axis would become unresponsive. After removing the string data, we didn't have an issue.

@joshhjacobson
Copy link
Contributor

@wraseman just to clarify, the string/names data was excluded from the clustering operation. I agree that working with a combination of string and numeric data might be a suspect however. Another important detail here is that all data actually needs to be stored as string values to be compatible with parcoords -- after performing the numeric computations, I would convert all data back to a string format anyway.

One last note: this issue stemmed from a slightly tweaked version of the basic example in this repo (see #15) so I think it's still an issue beyond our specific use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants