Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize fixes in a sibling fork #73

Open
ajbouh opened this issue Jul 20, 2019 · 1 comment
Open

Resize fixes in a sibling fork #73

ajbouh opened this issue Jul 20, 2019 · 1 comment

Comments

@ajbouh
Copy link

ajbouh commented Jul 20, 2019

@BigFatDog Thanks for this awesome port! I'm trying to embed parcoords-es in a way that supports resizing, brushing, and updating data. The combination of these three creates problems for me when using brush modes "1D-axes" and "1D-axes-multi".

It seems like some of this may be addressed by autodesk-forks/parallel-coordinates#1 and other recent commits in https://github.com/autodesk-forks/parallel-coordinates.

Is there any interest in trying to pull over these fixes? Or has the code diverged too much for that to be helpful?

@BigFatDog
Copy link
Owner

Hi @ajbouh
Thank you for your appreciation.
The autodesk fork that you mentioned are based on the original parallel-coordinates therefore that pull request cannot be applied to parcoords-es directly. Yes, the code has diverged too much.
I see two approaches here:

  • I contact autodesk team to see if they have any plan to port their contribution to parcoords-es. This is not an easy task for them, I'm afraid.
  • I port that pull request to parccords-es myself.

Currently I tend to adopt approach #2 because if autodesk would like to contribute, they would do it for all enhancements rather than this single feature.

I'll keep you updated here when I start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants