Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Const/Literal in Attribute names #1

Open
TheAngryByrd opened this issue Jun 1, 2020 · 0 comments
Open

Handling Const/Literal in Attribute names #1

TheAngryByrd opened this issue Jun 1, 2020 · 0 comments

Comments

@TheAngryByrd
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently we support using JsonProperty to customize the NamingStrategy of a backing field.

type DifferentBackingFieldSchema = {
    [<JsonProperty("not_one")>]
    one: int
    two: int
}

However this does not work when using a referenced Const/Literal such as:

module consts =
    let [<Literal>] not_one = "not_one"

type DifferentBackingFieldSchema = {
    [<JsonProperty(consts.not_one)>]
    one: int
    two: int
}

Describe the solution you'd like

I'd like to be able to use the Const/Literal value referenced in the attribute rather than inlining myself.

Describe alternatives you've considered
Inlining and dealing with the pain of duplication

Additional context
Upstream issue: MoiraeSoftware/myriad#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant