Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check JavaScripts too #40

Closed
szepeviktor opened this issue Sep 14, 2019 · 5 comments
Closed

Check JavaScripts too #40

szepeviktor opened this issue Sep 14, 2019 · 5 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Sep 14, 2019

You may look for a tool to guard JavaScript code quality.

A liberal choice is ESLint.

JSLint will teach you how to produce robust code. (although fiddly to use on the command line)

@BinaryMoon
Copy link
Owner

Hey Viktor - I was thinking about this yesterday and I added jshint and a test to my package.json - but I wasn't sure how to install jshint and run the test:
5abb4a5

@BinaryMoon
Copy link
Owner

Also - I was trying to add phpstan to my WordPress theme but it kept coming up with errors about unknown functions - mostly because I've added support for plugins.

It also came up with loads of errors about argument counts.

I ended up adding rules that ignored those errors entirely but that doesn't seem like the best thing to do:
https://github.com/BinaryMoon/jarvis/blob/master/phpstan.neon.dist#L34-L39

@szepeviktor
Copy link
Contributor Author

but I wasn't sure how to install jshint and run the test:

npm i && npm test ?

@szepeviktor
Copy link
Contributor Author

My notes are in BinaryMoon/jarvis#59

@BinaryMoon
Copy link
Owner

Gonna close this since jshint seems to be working well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants