Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Sign Up flow #4

Closed
15 tasks done
nikita-remeslov opened this issue Aug 16, 2024 · 7 comments · Fixed by #20 or #68
Closed
15 tasks done

FEAT: Sign Up flow #4

nikita-remeslov opened this issue Aug 16, 2024 · 7 comments · Fixed by #20 or #68
Assignees
Labels
FE Fronted feature QA QA tasks

Comments

@nikita-remeslov
Copy link
Collaborator

nikita-remeslov commented Aug 16, 2024

What feature?

  • Add /sign-up route
  • Add sign-up form
  • Add sign-up action flow
  • After form submission, the user is redirected to the app /
  • Save an authenticated user to the redux store
  • Add form validation
  • "Log in" link should navigate to the Sign In page

P.S. Sign In/Sing Up pages can use one layout

Add screenshots

image

Acceptance criteria

Following this Test Cases: https://docs.google.com/spreadsheets/d/1b-xRyyn39r4N9k-P7zC618jotIVunZbbz1Vv9ipHNOM/edit?gid=1854802596#gid=1854802596

  • Add a new route /sign-up to the application's routing configuration and ensure that navigating to /sign-up renders the sign-up form.
  • Develop a sign-up form that includes fields for user input, such as email, password, and any additional required fields (e.g., Full Name).
  • Ensure the form is styled consistently with the application's design and UX guidelines.
  • The sign-up form should be user-friendly and aligned with the layout used on the Sign In page if they share the same layout.
  • Implement the functionality to handle form submission, including sending the data to the backend API for user registration.
  • Upon successful form submission and authentication, the user should be redirected to the app's main page
  • Implement client-side validation for the sign-up form fields to ensure that all required fields are correctly filled out and that the input data meets the validation criteria
  • Display appropriate error messages for invalid input or failed sign-up attempts.
@nikita-remeslov nikita-remeslov added the FE Fronted feature label Aug 16, 2024
@nikita-remeslov nikita-remeslov added this to the Release 1.0 milestone Aug 16, 2024
@lfelix3011 lfelix3011 self-assigned this Aug 17, 2024
@lfelix3011 lfelix3011 linked a pull request Aug 20, 2024 that will close this issue
@lfelix3011 lfelix3011 moved this from In Progress to Peer Review in bsa-2024-outreachvids Aug 20, 2024
@nikita-remeslov nikita-remeslov added the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 20, 2024
@lfelix3011 lfelix3011 removed the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 20, 2024
@lfelix3011 lfelix3011 moved this from In Progress to Peer Review in bsa-2024-outreachvids Aug 20, 2024
@lfelix3011 lfelix3011 moved this from In Progress to Peer Review in bsa-2024-outreachvids Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Peer Review to Testing in bsa-2024-outreachvids Aug 23, 2024
@DaniellaZambrano DaniellaZambrano added the QA QA tasks label Aug 23, 2024
@DaniellaZambrano DaniellaZambrano self-assigned this Aug 23, 2024
@DaniellaZambrano
Copy link
Collaborator

DaniellaZambrano commented Aug 24, 2024

There is a visual issue the first time I type in the "Repeat Password" field: another eye icon appears, which is duplicated, and the color and shape are incorrect. This needs to be fixed

Steps to reproduce the issue: (Browser: Microsoft Edge Version 127.0.2651.105 (Official build) (64-bit))

  1. Open http://localhost:3000/sign-up
  2. Fill the "Repeat Password" field, since the first word the icon appears

Image with the issue:
Image

@DaniellaZambrano
Copy link
Collaborator

@lfelix3011 I'll be waiting for your response, thanks!

@lfelix3011
Copy link
Collaborator

lfelix3011 commented Aug 24, 2024

@DaniellaZambrano Thanks for the review, and QA, doing an amazing job looking for all the details and requirements.

I thinks that may be due to the browser, IE and Edge has a build in show and hide for input type password, but Firefox and Chrome don't have it.

If the theory is correct it should happens for all the inputs type password for that specific browser. Even though, tomorrow i will be confirming this, and implementing a solution, maybe using a pseudo element of css to hide that build in action of certain browsers, you can check the images that were taken when the task was completed in the link to the pull request below.

#20

Note: When the images was capture I was using Chrome

@DaniellaZambrano
Copy link
Collaborator

Yes you're right I forgot to put my browser sorry, I already update it

@lfelix3011
Copy link
Collaborator

@DaniellaZambrano Here is the implementation to hide the default reveal icon

Image

Here is the Pull Request #68

@lfelix3011 lfelix3011 moved this from In Progress to Peer Review in bsa-2024-outreachvids Aug 26, 2024
@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 27, 2024
@DaniellaZambrano
Copy link
Collaborator

DaniellaZambrano commented Aug 27, 2024

Hi @lfelix3011 , I don't think this message should be appears to an user

Edge:
Image

Opera:
Image

@nikita-remeslov nikita-remeslov mentioned this issue Aug 27, 2024
12 tasks
@lfelix3011 lfelix3011 moved this from In Progress to Peer Review in bsa-2024-outreachvids Aug 27, 2024
@DaniellaZambrano DaniellaZambrano moved this from To Be Tested to In Testing in bsa-2024-outreachvids Aug 28, 2024
@DaniellaZambrano
Copy link
Collaborator

@lfelix3011 Thanks for the feature at moment everything was ok!

@DaniellaZambrano DaniellaZambrano moved this from In Testing to Done in bsa-2024-outreachvids Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment