-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Sign Up flow #4
Comments
There is a visual issue the first time I type in the "Repeat Password" field: another eye icon appears, which is duplicated, and the color and shape are incorrect. This needs to be fixed Steps to reproduce the issue: (Browser: Microsoft Edge Version 127.0.2651.105 (Official build) (64-bit))
|
@lfelix3011 I'll be waiting for your response, thanks! |
@DaniellaZambrano Thanks for the review, and QA, doing an amazing job looking for all the details and requirements. I thinks that may be due to the browser, IE and Edge has a build in show and hide for input type password, but Firefox and Chrome don't have it. If the theory is correct it should happens for all the inputs type password for that specific browser. Even though, tomorrow i will be confirming this, and implementing a solution, maybe using a pseudo element of css to hide that build in action of certain browsers, you can check the images that were taken when the task was completed in the link to the pull request below. Note: When the images was capture I was using Chrome |
Yes you're right I forgot to put my browser sorry, I already update it |
@DaniellaZambrano Here is the implementation to hide the default reveal icon Here is the Pull Request #68 |
Hi @lfelix3011 , I don't think this message should be appears to an user |
@lfelix3011 Thanks for the feature at moment everything was ok! |
What feature?
P.S. Sign In/Sing Up pages can use one layout
Add screenshots
Acceptance criteria
Following this Test Cases: https://docs.google.com/spreadsheets/d/1b-xRyyn39r4N9k-P7zC618jotIVunZbbz1Vv9ipHNOM/edit?gid=1854802596#gid=1854802596
The text was updated successfully, but these errors were encountered: