Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: JWT token #5

Closed
6 of 7 tasks
nikita-remeslov opened this issue Aug 16, 2024 · 3 comments · Fixed by #22
Closed
6 of 7 tasks

FEAT: JWT token #5

nikita-remeslov opened this issue Aug 16, 2024 · 3 comments · Fixed by #22
Assignees
Labels
BE Backend feature QA QA tasks

Comments

@nikita-remeslov
Copy link
Collaborator

nikita-remeslov commented Aug 16, 2024

What feature?

  • Add token service to the backend with create and verify methods
  • The token should store a user id
  • The token should expire after 24h
  • Return token in response to the sign-in and sign-up

Lib for JWT token - https://www.npmjs.com/package/jose

Add screenshots

image

Acceptance criteria

  • A token is successfully created upon user sign-in and sign-up.
  • The token must be returned in the response after successful sign-in and sign-up.
  • The token should be securely encoded and decoded, ensuring that sensitive information (such as the user ID) is protected.
@nikita-remeslov nikita-remeslov added the BE Backend feature label Aug 16, 2024
@nikita-remeslov nikita-remeslov added this to the Release 1.0 milestone Aug 16, 2024
@stefano-lacorazza stefano-lacorazza self-assigned this Aug 16, 2024
@stefano-lacorazza
Copy link
Collaborator

To implement 'Return token in response to the sign-in and sign-up' I merged OV-2-add-sign-in-flow to OV-5-JWT-token

@stefano-lacorazza stefano-lacorazza linked a pull request Aug 20, 2024 that will close this issue
@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 20, 2024
@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 21, 2024
@anton-otroshchenko anton-otroshchenko added the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 21, 2024
@stefano-lacorazza stefano-lacorazza removed the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 22, 2024
@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 27, 2024
@nikita-remeslov nikita-remeslov added the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 27, 2024
@stefano-lacorazza stefano-lacorazza removed the MERGE CONFLICTS Merge conflicts while merging the PR label Aug 27, 2024
@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Peer Review to To Be Tested in bsa-2024-outreachvids Aug 29, 2024
@DaniellaZambrano DaniellaZambrano added the QA QA tasks label Aug 29, 2024
@DaniellaZambrano DaniellaZambrano self-assigned this Aug 29, 2024
@DaniellaZambrano DaniellaZambrano moved this from To Be Tested to In Testing in bsa-2024-outreachvids Aug 29, 2024
@DaniellaZambrano
Copy link
Collaborator

Excellent! Thanks. Just a question, why id is in that format?

Image

@DaniellaZambrano DaniellaZambrano moved this from In Testing to Done in bsa-2024-outreachvids Sep 2, 2024
@stefano-lacorazza
Copy link
Collaborator

Excellent! Thanks. Just a question, why id is in that format?

Image

The id is automatically created by the database when the user is created by user.repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Backend feature QA QA tasks
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants