Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Error handling #7

Closed
5 of 6 tasks
nikita-remeslov opened this issue Aug 16, 2024 · 2 comments · Fixed by #21
Closed
5 of 6 tasks

FEAT: Error handling #7

nikita-remeslov opened this issue Aug 16, 2024 · 2 comments · Fixed by #21
Assignees
@alien513
Labels
FE Fronted feature
Milestone
Pre-DEMO Release

Comments

@nikita-remeslov
Copy link
Collaborator

nikita-remeslov commented Aug 16, 2024 •
edited by alien513
Loading

What feature?

  • Implement error-handling middleware in the redux store
  • When an error occurs, show a toast notification

Doc: https://v2.chakra-ui.com/docs/components/toast/usage#standalone-toasts

P.S. For toast use out design styles

Add screenshots

No response

Acceptance criteria

  • The middleware should accurately detect errors
  • When an error occurs, a toast notification should be displayed to the user
  • Error message should be clear and concise, shouldn't contain unnecessary technical details and should be displayed in English
  • The site should continue to function, as much as possible, even in the presence of errors (avoid site crashing or freezing when an error occurs)

Testing documentation

https://docs.google.com/spreadsheets/d/1Dn7B49WQK0oi5bE3dmx_Ay1TH0Y1p3QUNDn3VvKWH0o/edit?gid=1927397104#gid=1927397104
@nikita-remeslov nikita-remeslov added the FE Fronted feature label Aug 16, 2024
@nikita-remeslov nikita-remeslov added this to the Release 1.0 milestone Aug 16, 2024
@WilsonBravo WilsonBravo self-assigned this Aug 17, 2024
@WilsonBravo WilsonBravo mentioned this issue Aug 20, 2024
Merged
@WilsonBravo WilsonBravo linked a pull request Aug 20, 2024 that will close this issue
OV-7: error handling #21
Merged
@github-project-automation github-project-automation bot moved this from Peer Review to Testing in bsa-2024-outreachvids Aug 23, 2024
@alien513 alien513 added the QA QA tasks label Sep 1, 2024
@alien513
Copy link
Collaborator

alien513 commented Sep 6, 2024 •
edited
Loading

Besides the standard clear messages such as the following:

Image

Image

There are also unclear messages like this:

Image

Bug added: #181

@nikita-remeslov nikita-remeslov moved this from Todo to Done in bsa-2024-outreachvids Sep 9, 2024
@alien513
Copy link
Collaborator

alien513 commented Sep 9, 2024

Created a bug: #184

@alien513 alien513 removed the QA QA tasks label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alien513 alien513

Labels
FE Fronted feature
Projects
bsa-2024-outreachvids
Status: Done
Milestone
Pre-DEMO Release
Development

Successfully merging a pull request may close this issue.

OV-7: error handling BinaryStudioAcademy/bsa-2024-outreachvids
3 participants
@nikita-remeslov @alien513 @WilsonBravo