Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] some unittests are actually integration tests #38

Open
jcapels opened this issue Dec 29, 2022 · 0 comments
Open

[FIX] some unittests are actually integration tests #38

jcapels opened this issue Dec 29, 2022 · 0 comments

Comments

@jcapels
Copy link
Collaborator

jcapels commented Dec 29, 2022

[FIX] some unittests are actually integration tests

For instance:

class TestEnsembles(TestCase):

    def setUp(self) -> None:
        self.data_path = os.path.join(TEST_DIR, 'data')

        dataset = os.path.join(self.data_path, "dataset_sweet_3d_balanced.sdf")
        loader = SDFLoader(dataset,
                           labels_fields='_SWEET')

        self.binary_dataset = loader.create_dataset()

        dataset = loader.create_dataset()
        splitter = SingletaskStratifiedSplitter()
        MorganFingerprint().featurize(dataset)
        self.train_dataset, self.test_dataset = splitter.train_test_split(dataset) 

This test is using the components SDFLoader, SingletaskStratifiedSplitter, and MorganFingerprint.

We should be mocking these methods in the unittests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant