Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have extract_array() accept non-integer dim() outputs #98

Open
MalteThodberg opened this issue Dec 7, 2021 · 1 comment
Open

Have extract_array() accept non-integer dim() outputs #98

MalteThodberg opened this issue Dec 7, 2021 · 1 comment

Comments

@MalteThodberg
Copy link

Upon a little experimentation, it seems the only thing preventing a big.matrix from the bigmemory package to be used as a Seed inside a DelayedArray is that dim() on a big.matrix returns a numeric and not an integer. This is caught by the check in extract_array() raising an error.

Would it be possible to relax this check to accept numeric as well as integer? Many on-disk matrix packages return numeric via dim() (bigmemory, filematrix, feather, fst, etc). It seems inconvenient to have to define a new Seed class for these packages just to reimplement the simple dim() function.

@nturaga
Copy link
Contributor

nturaga commented Apr 8, 2022

There are a lot of consequences to doing this, and we haven't considered this yet.

But this is probably a long-term change and won't happen right now. But I'll tag @hpages, in case he has a more detailed view on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants