Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-ux): added evm linear gradient for TD #1886

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix(ui-ux): added evm linear gradient for TD #1886

merged 3 commits into from
Oct 23, 2023

Conversation

fullstackninja864
Copy link
Contributor

@fullstackninja864 fullstackninja864 commented Oct 23, 2023 •
edited by lykalabrada
Loading

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-374

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

@fullstackninja864 fullstackninja864 self-assigned this Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit 417e5b3
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/653625ec7228100008645946
😎 Deploy Preview https://deploy-preview-1886--defi-scan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 32 (no change from production)
Accessibility: 75 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@linear
Copy link

linear bot commented Oct 23, 2023

DFC-374 Transfer Domain : EVM token name is incorrect in Defiscan

What happened?

What did you expect to happen?

Expected : DFI (EVM)

How to reproduce it (as minimally and precisely as possible):

Convert tokens DFI - DFI EVM

Txn Id : 4987e78f03e5c6bd7e1450ce6428aa869eb3be99f5b869cbc0d974dadfcd6a63

https://defiscan.live/transactions/4987e78f03e5c6bd7e1450ce6428aa869eb3be99f5b869cbc0d974dadfcd6a63?network=TestNet

image (2).png

Anything else that the team needs to know?

lykalabrada
lykalabrada previously approved these changes Oct 23, 2023
View reviewed changes
@lykalabrada lykalabrada enabled auto-merge (squash) October 23, 2023 07:40
@lykalabrada lykalabrada merged commit 24468b2 into main Oct 23, 2023
13 checks passed
@lykalabrada lykalabrada deleted the harsh/add-evm-svg branch October 23, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleleow kyleleow kyleleow approved these changes

@lykalabrada lykalabrada lykalabrada approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@pierregee pierregee Awaiting requested review from pierregee

@chloezxyy chloezxyy Awaiting requested review from chloezxyy

@G9000 G9000 Awaiting requested review from G9000

@JoshuaC817 JoshuaC817 Awaiting requested review from JoshuaC817

Assignees

@fullstackninja864 fullstackninja864

Labels
area/transactions kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fullstackninja864 @lykalabrada @kyleleow