Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethereum] ethereum websocket module #97

Open
1 task
florianlenz opened this issue Sep 5, 2018 · 1 comment
Open
1 task

[ethereum] ethereum websocket module #97

florianlenz opened this issue Sep 5, 2018 · 1 comment
Assignees
Milestone

Comments

@florianlenz
Copy link
Contributor

florianlenz commented Sep 5, 2018

Feature

we need to bring back the ethws module which got nuked in this module.

As a side note, we used this module to interact with ethereum smart contracts.

Acceptance Criteria

  • bring back the eth ws module as well as it's VM module.
@florianlenz florianlenz added this to the 1.3.0 milestone Sep 5, 2018
@borjantrajanoski borjantrajanoski self-assigned this Sep 5, 2018
@borjantrajanoski
Copy link
Contributor

I opened a PR and attempted to switch the mutex to channel state as I remember the locks were causing some issues in other parts of panthalassa. Looking for feedback if additional code or implementation is needed in regards to the ethws module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants