Merge master staging ln #3036
Merged
Merge master staging ln #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some error messages are only partly centered and have no padding to the edge of the container. Reason: Spinner is used in account and other components to show loading but also unknown error messages. Each line of the message is rendered in its own paragraph element. Those paragraphs are centered by the parent element using flexbox. As soon as a paragraph contains text that spawns over multiple lines it will cause the paragraph to use the full available width with left aligned text.
The transactions/transaction endpoint actually return "send", "receive" and "send_to_self" but the ITransaction type was "self" this was unnoticed because the type was never directly checked. But it should be the correct type, also in preparation for the frontend collaborative type implementation.
When the iOS app goes into the background, its TCP connections (Electrum server connetions) are killed after a while (~30s). When the user goes back into the app, we want to immediatelly trigger a reconnect, not waiting for the regular 30s reconnect timer. ``` go get github.com/BitBoxSwiss/block-client-go@924dde9 go mod tidy go mod vendor ```
We upgraded to Go 1.22 a while ago: https://go.dev/wiki/MinimumRequirements > For Go 1.21 and later: Windows 10 and higher or Windows Server 2016 > and higher. > Go 1.21 and later will support macOS Catalina 10.15 or newer; see https://go.dev/doc/go1.20#darwin. See also: - golang/go#57003 - golang/go#57125 - golang/go#64622 (comment) Windows 7 has oficially been EOL'd in Jan 2020, almost 5 years ago. It is reasonable to not officially support it.
There is no need to have these SVG's in JSX.
It has been failing with random errors way too often which is distracting: > 2024-10-11T07:40:25Z FATAL Fatal error init error: DB error: failed to download vulnerability DB: database download error: oci download error: failed to fetch the layer: GET https://ghcr.io/v2/aquasecurity/trivy-db/blobs/sha256:d5984d994db8053be4c3cb88a0358784726280ff174ad24bb84b92138b8f4acb: TOOMANYREQUESTS: retry-after: 1.021981ms, It also does not seem to help much beyond the builtin GH security scans.
The balance was using a smaller font-size so that both amounts, coin and currency, fit on one line. This was introduced a long time ago in b8cefe3 Removing as longer amounts break nicelly on small screens anyway and this 'optimization' is not really needed. Total balance should use a larger font-size.
So that the Balance is at the top of the screen.
Background of the progress ring was white in darkmode. Changed to be dark gray.
Fix regression introduced by: f564cfa The dependency on the aopp state in the `useEffec` hook caused infinite calls to the AOPP endpoint.
The app currently accepts dropping files into the app window and tries to render those. This will error with a blocked error without any way to go back making the app unusable. Added a hook to globally ignore dropped files.
Reduced from 10 vulnerabilities (8 low, 1 moderate, 1 high) to 8 low severity vulnerabilities.
The estimate (≈) symbol should be placed before the amount and sign
separated by a white-space.
Example:
≈ +100.-
The Android back button stopped working after the back button was used to close a dialog. The reason is that the backbutton pop handler did not remove the handler, as `slice(index, 1)` does not remove the element at `index`, it in fact keeps it. When properly removing the handler, back button behavior works as expected again.
The auth screen was sometimes showed for a very short time at startup even when it was disabled. This fixes the glitch, hiding the auth screen details while the backend checks if the auth config is enabled.
thisconnect
reviewed
Nov 11, 2024
There was a problem hiding this comment.
frontend merge LGTM
I checked these files mostly against master branch.
- frontends/web/src/components/balance/balance.tsx
- frontends/web/src/routes/account/summary/accountssummary.tsx
- frontends/web/src/routes/account/summary/balancerow.tsx
- frontends/web/src/routes/account/summary/chart.tsx
- frontends/web/src/routes/account/summary/summarybalance.tsx
- frontends/web/src/routes/router.tsx
Pls test building qt-osx. I didn't 😇
I can't build currently sorry.
and I can't open the app that was built with CI
MacOS % ./BitBox
dyld[20777]: Library not loaded: @loader_path/libbreez_sdk_bindings.dylib
Referenced from: <7332CD15-E38B-B766-D6C5-1BEE1C861254> /BitBox.app/Contents/Frameworks/libserver.so
Reason: tried: '/BitBox.app/Contents/Frameworks/libbreez_sdk_bindings.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64'))
zsh: abort ./BitBox
Conflicts: backend/coins/btc/handlers/handlers.go frontends/qt/Makefile frontends/web/src/components/balance/balance.tsx frontends/web/src/routes/account/summary/accountssummary.tsx frontends/web/src/routes/account/summary/balancerow.tsx frontends/web/src/routes/account/summary/chart.tsx frontends/web/src/routes/account/summary/summarybalance.tsx frontends/web/src/routes/router.tsx go.mod
Beerosagos
force-pushed
the
merge-master-staging-ln
branch
from
c413731 to
2af2d15
Compare
Beerosagos
force-pushed
the
merge-master-staging-ln
branch
from
2af2d15 to
ff4022a
Compare
|
@thisconnect added a commit to fix the qt-osx build, adapting to the universal build. PTAL 🙏 |
thisconnect
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
backend/coins/btc/handlers/handlers.go
frontends/qt/Makefile
frontends/web/src/components/balance/balance.tsx
frontends/web/src/routes/account/summary/accountssummary.tsx
frontends/web/src/routes/account/summary/balancerow.tsx
frontends/web/src/routes/account/summary/chart.tsx
frontends/web/src/routes/account/summary/summarybalance.tsx
frontends/web/src/routes/router.tsx
go.mod
Pls test building qt-osx. I didn't 😇