Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.45 merged #3047

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Conversation

thisconnect
Copy link
Collaborator

No description provided.

Beerosagos and others added 11 commits October 1, 2024 10:53
Also remove unused "button.buy" locize label.
With different translations the action buttons (send, receive, buy
& sell and WC) did not break nicely on small screen.

Due to limited button height the text could be outside of the button
and only visible in darkmode but not in normal mode (white on gray).

Changed to let the buttons break onto 2 lines of text if there is
not enough horozontal space.
this commit ensures consistent spacing between "Receiver address"
and "Transaction details" by using a container with fixed height
and margin, always rendered, regardless of coin control being
enabled or disabled.
…4.45-merged

Conflicts:
	frontends/android/BitBoxApp/app/build.gradle
	frontends/web/src/locales/ja/app.json
	frontends/web/src/routes/account/account.module.css
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisconnect thisconnect merged commit 84a6607 into BitBoxSwiss:master Nov 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants