-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: fix mobile remember wallet settings layout #3082
frontend: fix mobile remember wallet settings layout #3082
Conversation
align-items: flex-end; | ||
display: flex; | ||
flex-wrap: wrap; | ||
gap: 8px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flex gap seems to be working with our current chrome version now. Tested using macOS QT from CI.
EDIT: Discussed internally I̶t̶'s̶ m̶o̶r̶e̶ l̶i̶k̶e̶ a̶ p̶r̶o̶p̶o̶s̶a̶l̶ o̶n̶ h̶o̶w̶ i̶t̶ _̶c̶a̶n̶_̶ l̶o̶o̶k̶. W̶D̶Y̶T̶?̶ c̶c̶ @̶t̶h̶i̶s̶c̶o̶n̶n̶e̶c̶t̶ @̶j̶a̶d̶z̶e̶i̶d̶a̶n̶ W̶e̶ c̶a̶n̶ m̶a̶k̶e̶ t̶h̶e̶ "W̶a̶l̶l̶e̶t̶ m̶e̶r̶k̶e̶n̶" l̶a̶b̶e̶l̶ t̶o̶ b̶e̶ o̶n̶ t̶h̶e̶ b̶o̶t̶t̶o̶m̶ o̶f̶ t̶h̶e̶ s̶w̶i̶t̶c̶h̶ t̶o̶o̶ o̶n̶ s̶u̶p̶e̶r̶ s̶m̶a̶l̶l̶ s̶c̶r̶e̶e̶n̶ (̶l̶a̶s̶t̶ s̶c̶r̶e̶e̶n̶s̶h̶o̶t̶)̶, f̶o̶r̶ e̶x̶a̶m̶p̶l̶e̶. |
a5e409d
to
590d498
Compare
590d498
to
e7b6a85
Compare
PTAL 🙏 @thisconnect desktop alignment. Tried to have exactly the same with the current master, but still very slight difference exists but not significant imo. |
e7b6a85
to
d0f1b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in webdev LGTM thanks
Previously, the switch collapses if it has no enough space causing inconsistent layout between accounts. Now, that switch always stays on right edge top of the container. If there's no enough space, the name of the account and the switch label will collapse.
Before:
After:
After, on super small screen:
(the fingerprint is hidden when this screenshot was taken).