Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design soft fork message #121

Open
GBKS opened this issue Oct 1, 2024 · 2 comments
Open

Design soft fork message #121

GBKS opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels

Comments

@GBKS
Copy link
Contributor

GBKS commented Oct 1, 2024

The Qt application may show a cryptic warning that some unknown new rules were activated, as shown in the image. For more background, read this article.

image

We should come up with better phrasing for this message, and we need a general warning style (I think we have something already in our design system, but need to dig it out).

@GBKS GBKS added the design label Oct 1, 2024
@GBKS GBKS added this to the 1.8 Other / Design milestone Oct 1, 2024
@GBKS GBKS moved this to Todo in Bitcoin Core App Oct 1, 2024
@GBKS GBKS moved this to In Progress in Bitcoin Core App Design Roadmap Oct 1, 2024
@GBKS GBKS moved this from In Progress to Todo in Bitcoin Core App Design Roadmap Oct 1, 2024
@GBKS
Copy link
Contributor Author

GBKS commented Jan 22, 2025

@jarolrod could you maybe shed some light on this issue? Questions I am looking to answer for users:

  • Who activated those rules?
  • What are those rules?
  • What does versionbit 1 mean?
  • What am I supposed to do as a user?
  • Are my funds safe?

AI overlords have this to say.

Image

The recommended steps are pretty intense. I am hoping we can add some language in the application that informs users well so they don't have to resort to reading dev mailing lists (which are awesome reading material, but some people prefer romance novels).

@GBKS GBKS self-assigned this Jan 24, 2025
@GBKS GBKS moved this from Todo to In Progress in Bitcoin Core App Design Roadmap Jan 24, 2025
@GBKS GBKS moved this from Todo to In Progress in Bitcoin Core App Jan 24, 2025
@GBKS
Copy link
Contributor Author

GBKS commented Jan 24, 2025

First stab at a design. Under the block status is now a small notification that indicates pending or accepted soft forks. Users can click it to get more details.

Image

Some open questions/considerations:

  • When a soft fork is accepted, should users be notified the first time they open the wallet?
  • Should users be informed about what those new rules are, whether the app supports them, and how to use them?
  • Should the soft fork details include a link or reference to a place where users can get more info?
  • Do we need to design for 2+ soft forks in parallel (as BIP-9 makes explicitly possible)?
  • Is the placement under the block status appropriate? If, for example, we end up having a lot of pending soft forks around that may or may not happen, then the message will show up quite a bit and get annoying and unhelpful.
  • Not related to this screen, but what if the wallet has a transaction with unsupported rules? Can we pin it to a specific soft fork and show something like this screen as well? "This transaction uses the rule set 'Taproot', which is not supported..."

Anyhow, first stab, let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

1 participant